From 8de6b3c676188eca33129e743e3ff668e045d4e3 Mon Sep 17 00:00:00 2001
From: sue445 <sue445@sue445.net>
Date: Mon, 14 Oct 2024 11:38:02 +0900
Subject: [PATCH 1/2] Add `chomp` to `IO#readlines`

---
 core/io.rbs            |  2 +-
 test/stdlib/IO_test.rb | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/core/io.rbs b/core/io.rbs
index 711c1d265..49446d77f 100644
--- a/core/io.rbs
+++ b/core/io.rbs
@@ -1701,7 +1701,7 @@ class IO < Object
   #     # => ["First line", "Second line", "", "Fourth line", "Fifth line"]
   #     f.close
   #
-  def readlines: (?String sep, ?Integer limit) -> ::Array[String]
+  def readlines: (?String sep, ?Integer limit, ?chomp: boolish) -> ::Array[String]
 
   # <!--
   #   rdoc-file=io.c
diff --git a/test/stdlib/IO_test.rb b/test/stdlib/IO_test.rb
index 498297fe7..566365e1f 100644
--- a/test/stdlib/IO_test.rb
+++ b/test/stdlib/IO_test.rb
@@ -382,6 +382,22 @@ def test_gets
                        io, :gets, nil, chomp: true
     end
   end
+
+  def test_readlines
+    IO.open(IO.sysopen(File.expand_path(__FILE__))) do |io|
+      assert_send_type '() -> Array[String]',
+                       io, :readlines
+
+      assert_send_type '(String, Integer) -> Array[String]',
+                       io, :readlines, "\n", 100
+
+      assert_send_type '(chomp: bool) -> Array[String]',
+                       io, :readlines, chomp: true
+
+      assert_send_type '(String, Integer, chomp: bool) -> Array[String]',
+                       io, :readlines, "\n", 100, chomp: true
+    end
+  end
 end
 
 class IOWaitTest < Test::Unit::TestCase

From 7a7069575bee4c3517a7808ab6aa76e2e3a00e4d Mon Sep 17 00:00:00 2001
From: sue445 <sue445@sue445.net>
Date: Mon, 14 Oct 2024 12:14:51 +0900
Subject: [PATCH 2/2] Add `chomp` to `IO#readline`

---
 core/io.rbs            |  2 +-
 test/stdlib/IO_test.rb | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/core/io.rbs b/core/io.rbs
index 49446d77f..9ee8110d5 100644
--- a/core/io.rbs
+++ b/core/io.rbs
@@ -1638,7 +1638,7 @@ class IO < Object
   # Optional keyword argument `chomp` specifies whether line separators are to be
   # omitted.
   #
-  def readline: (?String sep, ?Integer limit) -> String
+  def readline: (?String sep, ?Integer limit, ?chomp: boolish) -> String
 
   # <!--
   #   rdoc-file=io.c
diff --git a/test/stdlib/IO_test.rb b/test/stdlib/IO_test.rb
index 566365e1f..90a820e1d 100644
--- a/test/stdlib/IO_test.rb
+++ b/test/stdlib/IO_test.rb
@@ -398,6 +398,22 @@ def test_readlines
                        io, :readlines, "\n", 100, chomp: true
     end
   end
+
+  def test_readline
+    IO.open(IO.sysopen(File.expand_path(__FILE__))) do |io|
+      assert_send_type '() -> String',
+                       io, :readline
+
+      assert_send_type '(String, Integer) -> String',
+                       io, :readline, "\n", 100
+
+      assert_send_type '(chomp: bool) -> String',
+                       io, :readline, chomp: true
+
+      assert_send_type '(String, Integer, chomp: bool) -> String',
+                       io, :readline, "\n", 100, chomp: true
+    end
+  end
 end
 
 class IOWaitTest < Test::Unit::TestCase