Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errer mesage for property #531

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Improve errer mesage for property #531

merged 2 commits into from
Oct 1, 2024
+51 −16

Conversation

ledsun
Copy link
Contributor

@ledsun ledsun commented Sep 30, 2024

This work was originally done in #527.
After trying, I thought it would be a good idea to improve the message when a property of a JavaScript object is called as a method.

I hope this will help users quickly realize that they can't call a property as a method and their surprise will be tiny.

kateinoigakukun
kateinoigakukun approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit d5da762 into ruby:main Oct 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ledsun @kateinoigakukun