-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Introduce install_or_cli_help and use it default bundle command
#9136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #9124 This behavior is a deeply entrenched convention and changing it will annoy lots of developers with unclear gains.
As mentioned in #9124, the intent for changing the default command was to be more welcoming. I think we can acheive that by attempting to install, but to print that same help message if there is no Gemfile. That should address both concerns.
dentarg
reviewed
Nov 29, 2025
| MSG | ||
| unless Bundler.settings[:default_cli_command] | ||
| Bundler.ui.info <<-MSG | ||
| In the feature version of Bundler, running `bundle` without argument will no longer run `bundle install`. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| In the feature version of Bundler, running `bundle` without argument will no longer run `bundle install`. | |
| In a future version of Bundler, running `bundle` without argument will no longer run `bundle install`. |
eregon
reviewed
Nov 29, 2025
| Bundler.ui.info <<-MSG | ||
| In the feature version of Bundler, running `bundle` without argument will no longer run `bundle install`. | ||
| Instead, the `cli_help` command will be displayed. Please use `bundle install` explicitly for scripts like CI/CD. | ||
| If you wish to use feature behavior now with `bundle config set default_cli_command cli_help --global` |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| If you wish to use feature behavior now with `bundle config set default_cli_command cli_help --global` | |
| You can use the future behavior now with `bundle config set default_cli_command cli_help --global`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
installis not helpful outside ofGemfilelocation. This change show thecli_helpif it raisedGemfileNotFound. This change created by @byrootAnd I update the current warn message to info level. and it will not display if
default_cli_commandvalue is present.Closes #9125
Closes #9126