Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs for deprecated methods #780

Open
andrykonchin opened this issue Jul 19, 2020 · 1 comment
Open

Specs for deprecated methods #780

andrykonchin opened this issue Jul 19, 2020 · 1 comment

Comments

@andrykonchin
Copy link
Member

There are some deprecated/obsolete methods like File.exists?, Thread#safe_level etc in the core library.

Looks like they aren't covered with tests there and moreover some existing specs were deleted recently - File.exists?, Dir.exists? and FileTest.exists?` (commit).

So I am wondering whether it is a well-considered decision or it's unintentional situation. I believe that as far as these methods are still available in MRI they should be a part of the specification.

@eregon
Copy link
Member

eregon commented Jul 20, 2020

I agree, the specs should remain as long as there is a non-EOL version that supports it.

We just need to find a way to silence those deprecation warnings for the deprecated but ideally not for the non-deprecated methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants