You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm implementing Class#{subclasses,descendants} in Opal. While in MRI GC may run quite consistently for this test to always pass, in Opal we have to rely on JS behavior - and it doesn't help us. A similar situation may happen on other Ruby implementations.
Of course not, it's unintentional. Could you make a PR to fix it?
I think it's best to use a separate hierarchy for the descendants/subclasses specs to avoid unintentional subclasses like that one.
I'm implementing
Class#{subclasses,descendants}
in Opal. While in MRI GC may run quite consistently for this test to always pass, in Opal we have to rely on JS behavior - and it doesn't help us. A similar situation may happen on other Ruby implementations.Let's take a look at this:
spec/core/class/descendants_spec.rb
Line 7 in 12c704a
And then this:
spec/core/module/remove_method_spec.rb
Line 37 in 12c704a
A question would be - do we really want to hardcode a need for GC for this part or an assumption that it will be ran between those 2 tests?
The text was updated successfully, but these errors were encountered: