Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Required Partner Fields field missing in organization (discovered on staging). #3420

Closed
2 tasks
cielf opened this issue Mar 2, 2023 · 6 comments · Fixed by #3421
Closed
2 tasks

[BUG] Required Partner Fields field missing in organization (discovered on staging). #3420

cielf opened this issue Mar 2, 2023 · 6 comments · Fixed by #3421
Assignees
Labels
BLOCKER This issue blocks others and should be prioritized 🐞 Bug Help Wanted Groomed + open to all! In Progress

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 2, 2023

Summary

In the organization edit, the "Required Partner Fields" field is missing (the label is there, but not the field)

Details

Recreation

Sign onto staging as org_admin1@example.com, My Organization | Edit. You'll see "Required Partner Fields" but no accompanying field.

Criteria for completion

  • Field is there

Bonus round

  • Add tests to confirm field presences on the organization edit
@walterbenson
Copy link

I can pick this up

@dorner
Copy link
Collaborator

dorner commented Mar 2, 2023

Go for it :)

@cielf
Copy link
Collaborator Author

cielf commented Mar 2, 2023

FYI, this is currently blocking our next release. But I expect/hope it will be obvious what's going on once you poke at it!

@cielf cielf added Help Wanted Groomed + open to all! In Progress BLOCKER This issue blocks others and should be prioritized 🐞 Bug labels Mar 2, 2023
@walterbenson
Copy link

walterbenson commented Mar 3, 2023

I don't have a solution but I do have an idea of the problem. Unfortunately not something I can fix quick and easy.

This PR 3209 Enable and use import maps removes webpack which I think broke the usage of bootstrap-select. Bootstrap was added in the same pr which added partner fields. I reset the branch to before the merge with git reset --hard d8f6b3d and the field returned so I'm reasonably sure that PR 3209 is the issue.

I doubt y'all want to revert PR 3209 and this is my first contact with import maps so probably best if someone with more context around this project takes this over given it's blocking a release. @cielf

@cielf
Copy link
Collaborator Author

cielf commented Mar 3, 2023

Thanks for the investigation @walterbenson -- I'm afraid I suspected something like that. It looks like I missed this particular thing when testing. Another thing for @dorner to look into, I'm afraid.

@cielf
Copy link
Collaborator Author

cielf commented Mar 11, 2023

Fixed by #3421. Closing

@cielf cielf closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKER This issue blocks others and should be prioritized 🐞 Bug Help Wanted Groomed + open to all! In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants