-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter pets by fostered on staff pet view #795
Comments
Ideas for Desired Filters
I would like to implement more granular filters like the following:
It feels like this would require a change in design for the This is mainly driven by the |
Thanks @kasugaijin for removing the assigned label. I got way too busy when I came home to finish this up. For anyone who wants to pick this up, the WIP code is in branch That would be a good place to pick back up on this issue. Ping me with any questions! |
I could take this issue on 🙋 Out of all the filters mentioned by @meg-gutshall, the only one that looks like it would be more effort to implement is the "Completed Fosters" filter (if this would return all pets that were fostered in their past, regardless of their current status). This seems like it would require an additional table for recording adoption/fostering history. Should we create this kind of pet adoption status history table, or for now just provide all the filters that don't require information on a pet's previous state? |
Hey @coalest I have some thoughts here - let me know what you think Proposed filters for
Foster Related Filters (not required - we already have filters doing this on on Also - would be great to move Ransack logic on the |
Description
On the staff pets view,
/staff/pets
, we cannot filter pets by if they are fosterable or fostered. Currently, they only show "adopted" and "unadopted".These filters work with ransack, and they may benefit from being reworked from their current state.
I haven't fully thought through this. If you have suggestions, let's think about how this works and make a clearer idea of what these options should be and what their names on the UI should be.
The cases desired to show:
Acceptance criteria
The text was updated successfully, but these errors were encountered: