Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Make element selectors in browser tests valid for BiDi #18133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torokati44
Copy link
Member

I've extracted these changes from #17539 just to reduce the miscellaneous diff noise in there.

@torokati44 torokati44 added A-web Area: Web & Extensions T-refactor Type: Refactor / Cleanup labels Oct 1, 2024
@torokati44 torokati44 added A-tests Area: Tests & Test Framework and removed A-web Area: Web & Extensions labels Oct 1, 2024
@danielhjacobs
Copy link
Contributor

Oh sorry, this shouldn't be needed with the next webdriverio release: webdriverio/webdriverio#13694

@torokati44
Copy link
Member Author

Ah, okay, no worries! Since it's already here... I leave it up to you whether this is merged, or closed and the changes thrown away (and removed from #17539 too then, I guess).
I really don't mind either way. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: Tests & Test Framework T-refactor Type: Refactor / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants