New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing import #2

Open

lukasc-ch opened this issue Mar 6, 2020 · 0 comments

lukasc-ch commented Mar 6, 2020

Hi there
This is just for sharing in case others experience the same issue and I don't have time for a pull request:

In libs/openpose/openpose/render.hpp there is the "#include " missing
For the CMakeLists.txt it would be better to has

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

instead of setting it explicitly with

set(CMAKE_CXX_FLAGS "-std=c++11 -fPIC" CACHE STRING "compile flags" FORCE)

Users should know to adjust the path to pybind11, since it is written down explicitly:

set(PYBIND11_CMAKE_DIR "XXXXX/share/cmake/pybind11" CACHE PATH "pybind11 CMake directory")

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment