Add Yama Overhead Audio plugin

[mattiasen1]

Adds the Yama Overhead Audio plugin.

Thhis plugin plays an audiofile depending on what overhead text is displayed above Yama. Includes a volume slider, README, icon, and BSD-2-Clause license.

[runelite-github-app]

New plugin yama-overhead-audio: https://github.com/mattiasen1/yama-overhead-audio/tree/8c76c76ff253422868f3482270c724f9d1b5b2ae

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[cdfisher]

This seems like it would go against Jagex's third-party client guidelines.

Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper.

Indicates the time where a boss mechanic may start or end

[mattiasen1]

It could, though it is not like Sol Heredit where it actually helps, because the attacks at Yama are in a set pattern, and the overheads are most of the time just nonsense. But if it is a clear violation, then I agree.

[mattiasen1]

There are also other examples where a plugin does this. ToB at Sote and Verzik there is a plugin that has a sound effect when you are targeted by the death balls. And one when Xarpus screeches.

[mattiasen1]

@cdfisher I also found that the Boss Voicer Plugin actually has voicings for Sol Heredits grapple attack. Do you have any suggestion to how I can check the legality of my plugin? It is intended purely for entertainment purposes and not assistance in gameplay.

[riktenx]

IMO like you said we have nex voiceover, so as long as this is triggering explicitly on existing overhead text I want to say it's OK. If someone more tenured than me disagrees please state.

We do need to know the source of these sound files to ensure they are licenseable.

[mattiasen1]

@riktenx I recorded the audio files myself. do I need to add anything specific to state that?

[riktenx]

Maybe just indicate it in the readme if you don't mind.

[mattiasen1]

@riktenx Done!