Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace -p with ENV Variable #15

Open
ambsw-technology opened this issue Apr 29, 2019 · 1 comment · May be fixed by #19
Open

Replace -p with ENV Variable #15

ambsw-technology opened this issue Apr 29, 2019 · 1 comment · May be fixed by #19

Comments

@ambsw-technology
Copy link

It seems to me that the following will result in the deletion of many keys:

  • ssm-diff init -p "a/b/c"
  • ssm-diff plan -p "a/b/c"
  • ssm-diff apply

It would be easy to forget to append the -p flag. If this would result in massive deletions, it seems like a very dangerous design. I suggest moving the -p behavior into an ENV variable. This ensures that it must be deliberately altered, not merely forgotten.

@ambsw-technology
Copy link
Author

Obviously, this change would require a syntactical change. I propose to accept ; and : as SSM path separators so the syntax parallels the PATH definitions on windows and linux.

claytondaley added a commit to ambsw/ssm-diff that referenced this issue Apr 30, 2019
…variable to exclude secure tags from processing (fixes runtheops#13)
claytondaley added a commit to ambsw/ssm-diff that referenced this issue May 1, 2019
…nd line flags to ENV variables (fixes runtheops#15), (2) a way to generate YAML files for branches of the SSM tree (closes runtheops#11), and (3) the ability to ignore SecureString keys if they are not necessary (closes runtheops#13), and (4) the introduction of metadata in the YAML files to permit compatibility checking (more general fix for runtheops#15 with support for new features)
claytondaley added a commit to ambsw/ssm-diff that referenced this issue May 1, 2019
…nd line flags to ENV variables (fixes runtheops#15), (2) a way to generate YAML files for branches of the SSM tree (closes runtheops#11), and (3) the ability to ignore SecureString keys if they are not necessary (closes runtheops#13), and (4) the introduction of metadata in the YAML files to permit compatibility checking (more general fix for runtheops#15 with support for new features)
@ambsw-technology ambsw-technology linked a pull request May 1, 2019 that will close this issue
claytondaley added a commit to ambsw/ssm-diff that referenced this issue May 1, 2019
…nd line flags to ENV variables (fixes runtheops#15), (2) a way to generate YAML files for branches of the SSM tree (closes runtheops#11), and (3) the ability to ignore SecureString keys if they are not necessary (closes runtheops#13), and (4) the introduction of metadata in the YAML files to permit compatibility checking (more general fix for runtheops#15 with support for new features)
claytondaley added a commit to ambsw/ssm-diff that referenced this issue May 1, 2019
…nd line flags to ENV variables (fixes runtheops#15), (2) a way to generate YAML files for branches of the SSM tree (closes runtheops#11), (3) the ability to ignore SecureString keys if they are not necessary (closes runtheops#13), (4) support for the SSM StringList type and more timely type coercion so e.g. YAML integers and SSM strings match, and (5) the introduction of metadata in the YAML files to permit compatibility checking (more general fix for runtheops#15 with support for new features)
claytondaley added a commit to ambsw/ssm-diff that referenced this issue May 1, 2019
…nd line flags to ENV variables (fixes runtheops#15), (2) a way to generate YAML files for branches of the SSM tree (closes runtheops#11), (3) the ability to ignore SecureString keys if they are not necessary (closes runtheops#13), (4) support for the SSM StringList type and more timely type coercion so e.g. YAML integers and SSM strings match, and (5) the introduction of metadata in the YAML files to permit compatibility checking (more general fix for runtheops#15 with support for new features)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant