Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new design for categories page #2177

Closed
Anmol-Baranwal opened this issue Nov 1, 2023 · 9 comments · Fixed by #2195
Closed

feat: add new design for categories page #2177

Anmol-Baranwal opened this issue Nov 1, 2023 · 9 comments · Fixed by #2195
Assignees
@gakshita
Labels
development Still being developed goal: new-design Design related issues 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Nov 1, 2023 •
edited by rupali-codes
Loading

You can view the figma file here.

image

The design should be responsive.

ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • You also need to implement breadcrumbs based on the current category we are currently on.

image

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.

⚠️ Make sure to push all the changes into dev branch
@Anmol-Baranwal Anmol-Baranwal mentioned this issue Nov 1, 2023
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@Anmol-Baranwal Anmol-Baranwal changed the title Category Page feat: add new design for categories page Nov 1, 2023
@rupali-codes rupali-codes added goal: new-design Design related issues development Still being developed up for grabs this issue open for the taking 🚀 ready and removed 🔒 locked labels Nov 2, 2023
Repository owner unlocked this conversation Nov 2, 2023
@gakshita
Copy link
Contributor

Hey i would like to take this up @rupali-codes

@CBID2
Copy link
Collaborator

CBID2 commented Nov 14, 2023

Go ahead @gakshita

@CBID2 CBID2 removed the up for grabs this issue open for the taking label Nov 14, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

@gakshita
Please tag any of the maintainers, if you face any problem. We will help you properly.

@rupali-codes
Copy link
Owner

@gakshita any updates?

@gakshita
Copy link
Contributor

Yes, I will submit the PR today.

@Anmol-Baranwal
Copy link
Collaborator Author

Yes, I will submit the PR today.

Please remember to push the changes to dev branch.

image

@gakshita
Copy link
Contributor

I don't have the access to push to dev branch

@gakshita gakshita mentioned this issue Nov 25, 2023
Merged
@Anmol-Baranwal
Copy link
Collaborator Author

Anmol-Baranwal commented Nov 26, 2023 •
edited
Loading

I don't have the access to push to dev branch

@rupali-codes
Do we need access to push to dev?

Please let her know.

@Anmol-Baranwal Anmol-Baranwal linked a pull request Nov 26, 2023 that will close this issue
Feat: add new design for categories page #2195
Merged
@CBID2 CBID2 reopened this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gakshita gakshita

Labels
development Still being developed goal: new-design Design related issues 🚀 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add new design for categories page gakshita/LinksHub
4 participants
@gakshita @Anmol-Baranwal @rupali-codes @CBID2