Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add searchbar for mobile devices (new design) #2202

Closed
Anmol-Baranwal opened this issue Dec 8, 2023 · 8 comments · Fixed by #2226
Closed

feat: add searchbar for mobile devices (new design) #2202

Anmol-Baranwal opened this issue Dec 8, 2023 · 8 comments · Fixed by #2226
Assignees
Labels
goal: new-design Design related issues priority: high Making completely new feature 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

You can view the figma file here.

image
image

The design should be responsive.


ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • The nav menu is implemented in dev branch, so make sure to fork the dev branch as well. Then you can use the existing code easily.

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.


⚠️ Make sure to push all the changes into dev branch

@Anmol-Baranwal Anmol-Baranwal added goal: new-design Design related issues 🚀 ready priority: high Making completely new feature labels Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Hello Anmol-Baranwal!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@JoshiUtsav
Copy link
Contributor

@Anmol-Baranwal could you assign this to me.

@Anmol-Baranwal
Copy link
Collaborator Author

@Anmol-Baranwal could you assign this to me.

I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

@heysolomon
Copy link
Contributor

Hey @Anmol-Baranwal can I jump on this?

@Anmol-Baranwal
Copy link
Collaborator Author

Hey @Anmol-Baranwal can I jump on this?

@JoshiUtsav
Are you working on this? If not, let me know so I can assign heysolomon.

@JoshiUtsav
Copy link
Contributor

@Anmol-Baranwal assign this task to him.

@Anmol-Baranwal
Copy link
Collaborator Author

@Anmol-Baranwal assign this task to him.

@heysolomon
I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

Also, please let us know by when you can complete it. We usually don't ask, but in many recent high priority issues, people leave it unattended after getting assigned and unassign themselves after 25 days or a month.

Therefore, there is no strict time constraint, but we would appreciate it if you could provide an expected date. This date can, of course, be extended :)

@heysolomon
Copy link
Contributor

@Anmol-Baranwal assign this task to him.

@heysolomon I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

Also, please let us know by when you can complete it. We usually don't ask, but in many recent high priority issues, people leave it unattended after getting assigned and unassign themselves after 25 days or a month.

Therefore, there is no strict time constraint, but we would appreciate it if you could provide an expected date. This date can, of course, be extended :)

Okay. I will be done on or before Friday this week.

@JoshiUtsav JoshiUtsav removed their assignment Dec 28, 2023
heysolomon added a commit to heysolomon/LinksHub that referenced this issue Dec 29, 2023
@CBID2 CBID2 linked a pull request Dec 29, 2023 that will close this issue
rupali-codes added a commit that referenced this issue Jan 9, 2024
* feat: add searchbar for mobile devices (#2202)

* fix: vercel deployment

* fixed scrollbar visibility in light mode

---------

Co-authored-by: Rupali Haldiya <rupali7487@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-design Design related issues priority: high Making completely new feature 🚀 ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants