Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal UI Improvement: Add Space Between Title and Copy Button #2230

Closed
2 of 3 tasks
lokeshvasnik opened this issue Jan 5, 2024 · 6 comments · Fixed by #2232
Closed
2 of 3 tasks

Modal UI Improvement: Add Space Between Title and Copy Button #2230

lokeshvasnik opened this issue Jan 5, 2024 · 6 comments · Fixed by #2232
Assignees
@lokeshvasnik
Labels
priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish 🚀 ready

Comments

@lokeshvasnik
Copy link
Contributor

Description

Issue:
The current modal layout displays the title and copy button without proper spacing, causing them to stick together.

Screenshots

Screenshot from 2024-01-05 17-06-58
Untitled design

Any additional information?

Contributor Guidelines:

Ensure that the changes do not affect the responsiveness of the modal.
Test the modifications across different screen sizes to guarantee a consistent user experience.

What browser are you seeing the problem on?

No response

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@lokeshvasnik lokeshvasnik added bug Something isn't working priority: medium Modifying an existing feature labels Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes @CBID2 @aftabrehan
What do you think?

@CBID2
Copy link
Collaborator

CBID2 commented Jan 6, 2024

@rupali-codes @CBID2 @aftabrehan

What do you think?

I think the change would be ok @Anmol-Baranwal. How about you @aftabrehan and @rupali-codes?

@aftabrehan
Copy link
Collaborator

@rupali-codes @CBID2 @aftabrehan

What do you think?

I think the change would be ok @Anmol-Baranwal. How about you @aftabrehan and @rupali-codes?

Of course, there should be a gap between title and copy button.

@Anmol-Baranwal
Copy link
Collaborator

@lokeshvasnik
I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

@Anmol-Baranwal Anmol-Baranwal added quick-fix Shouldn't take much time to finish 🚀 ready priority: low Addition of new links/categories or doing any small task (e.g fixing typos) and removed bug Something isn't working 🔒 locked priority: medium Modifying an existing feature labels Jan 7, 2024
Repository owner unlocked this conversation Jan 7, 2024
@lokeshvasnik
Copy link
Contributor Author

Looks good 🚀
Screenshot from 2024-01-07 19-21-19
Screenshot from 2024-01-07 19-23-16

@lokeshvasnik lokeshvasnik mentioned this issue Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokeshvasnik lokeshvasnik

Labels
priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish 🚀 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix copytoclipboard button gap issue #2230 lokeshvasnik/LinksHub
4 participants
@Anmol-Baranwal @lokeshvasnik @aftabrehan @CBID2