Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Duplicate Tailwind class names #2442

Closed
4 tasks done
Jay-Karia opened this issue Jul 30, 2024 · 6 comments · Fixed by #2452
Closed
4 tasks done

[Refactor] Duplicate Tailwind class names #2442

Jay-Karia opened this issue Jul 30, 2024 · 6 comments · Fixed by #2452
Assignees
Labels
chore Might take time to finish goal: refactor Refactoring the codebase priority: medium Modifying an existing feature

Comments

@Jay-Karia
Copy link
Contributor

Jay-Karia commented Jul 30, 2024

File Name

pages/index.tsx

Reason for Refactoring the Code

I can find multiple instances in this file where there is duplication of tailwind class names.

duplicate 1
dup 2

more duplicate classnames found in pages/[category]/index.tsx
repeating

Checklist

  • I have checked the existing issues.
  • I have read the Contributing Guidelines.
  • The changes don't break the code and don't introduce new functionality.
  • I am willing to work on this issue (optional).
@Jay-Karia Jay-Karia added goal: refactor Refactoring the codebase priority: medium Modifying an existing feature labels Jul 30, 2024
Copy link

#2439, #2438, #2436, #2435, #2434, #2430, #2428, #2427 is already opened by you
As per contributing guidelines, you can only work on 1 issue at a time.

Copy link

Hello Jay-Karia!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

This was referenced Jul 30, 2024
@rupali-codes
Copy link
Owner

@Jay-Karia thanks Jay. For now, we are opening this issue for others to work, because you already have an issue assigned. When your current PRs gets merged/closed and nobody takes this issue, we will assign it to you.

@Hachondeoro
Copy link
Contributor

Hachondeoro commented Aug 3, 2024

@rupali-codes Can I get assigned this issue?

@rupali-codes
Copy link
Owner

@rupali-codes Can I get assigned this issue?

Sure, assigning it to you, please have a look at our Contributing guidelines and let us know if you need any assistance. Thanks.

Copy link

github-actions bot commented Aug 4, 2024

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: refactor Refactoring the codebase priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants