Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTHER] Add background color in the resource card in light theme #2463

Closed
2 of 3 tasks
rupali-codes opened this issue Aug 7, 2024 · 4 comments · Fixed by #2466
Closed
2 of 3 tasks

[OTHER] Add background color in the resource card in light theme #2463

rupali-codes opened this issue Aug 7, 2024 · 4 comments · Fixed by #2466
Assignees
@AlexMutig
Labels
chore Might take time to finish first-timers This label is for people who contributing in open-source for first time good first issue Good for newcomers priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish

Comments

@rupali-codes
Copy link
Owner

What would you like to share or ask?

The resource card have no background color on light theme.

image

Add light-gray background color and a slight border same as the category page.

image

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@rupali-codes rupali-codes added good first issue Good for newcomers up for grabs this issue open for the taking quick-fix Shouldn't take much time to finish first-timers This label is for people who contributing in open-source for first time priority: low Addition of new links/categories or doing any small task (e.g fixing typos) chore Might take time to finish labels Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Hello rupali-codes!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@AlexMutig
Copy link

AlexMutig commented Aug 7, 2024 •
edited
Loading

I am new to open source projects and would be glad if i could work on this one

@rupali-codes rupali-codes removed the up for grabs this issue open for the taking label Aug 8, 2024
@rupali-codes
Copy link
Owner Author

@AlexMutig you're assigned, please do not forget to read & follow our Contributing Guidelines. Let us know if you need any assistance.

AlexMutig pushed a commit to AlexMutig/LinksHub that referenced this issue Aug 9, 2024
chore: Add background and border for resource card (rupali-codes#2463)
96e34ed
@rupali-codes rupali-codes linked a pull request Aug 11, 2024 that will close this issue
chore: Add background and border for resource card (#2463) #2466
Merged
rupali-codes added a commit that referenced this issue Aug 11, 2024
@rupali-codes
chore: Add background and border for resource card (#2463)
f4bf483
@github-actions GitHub Actions
Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexMutig AlexMutig

Labels
chore Might take time to finish first-timers This label is for people who contributing in open-source for first time good first issue Good for newcomers priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add background and border for resource card (#2463) AlexMutig/LinksHub
2 participants
@rupali-codes @AlexMutig