-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nom is included in public API #516
Comments
Was looking at switching from This would drop the total dependency count by 2-3:
|
That's indeed an issue, yes. Thanks for raising this! I am happy with either, a patch to fix the issue you raised here, or a patch(set) to move from That said, I would like to offer you maintainership on this crate, if you want it. I am only passively maintaining this and I had little motivation to drive this crate forward in the past... even my |
I'm fine doing the change but it is a breaking change and unsure how you feel about doing one so soon after the last... As for maintainership, I would likely be passive about it as I don't even use this crate. I was making these changes mostly because they are low hanging and this is used by so many people. |
If I help out or take over, I would update the crate to conform to all of my other crates so that the incremental overhead of taking care of this crate is dramatically lower. To achieve that, i would like full privileges so I can make any changes to the github side of this to support the above (e.g. install "apps"). |
If you do get approval, before tackling all that could you please give me a heads-up with a window / notice of about a week? I'm planning to wrap up my open PRs this month and the less friction to deal with from rebasing those the easier it'll be to get them resolved 😅 |
See
ConfigError::ParsePath
.This makes upgrading nom or moving away from it a breaking change.
The text was updated successfully, but these errors were encountered: