chore: Use a common method in parsers to check root is a table #469
Conversation
polarathene
force-pushed
the
chore/common-parser-root-check
branch
from
c01c0a5
to
095bb32
Compare
There was a problem hiding this comment.
Looks good to me.
@polarathene You're pretty active here, thank you for your contributions! I want to note that I have been working on a complete overhaul of the config-rs codebase here: https://github.com/matthiasbeyer/config-rs-ng/ for some time, but have been stalled. Maybe you want to have a look?
You're welcome! It's not much but I try lend a hand when I can spare the time.
I would, but I have quite the backlog elsewhere to catchup on 😅 (I'm also not too experienced with Rust) I just wanted to try pitch in some time to help with the two stale config features, and afterwards I figured these two recent PRs were small enough improvements to throw your way :) I understand with things taking time and stalling, some of my own are dragging out by 1-2 years, some even longer 😝 |
|
Clippy failures aren't related to this PR, how would you like them resolved? |
|
Hm, with 1.70.0, these clippy failures do not appear on master for me? 👀 |
They're all on the master branch, this PR doesn't touch these files and the CI is catching them 🤷♂️
|
|
Ah, yes. I was using 1.70.0, but CI obviously runs 1.73.0. I will push a fix in a few minutes! |
|
After #471 is merged you can rebase for fixes to these issues. |
Signed-off-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
polarathene
force-pushed
the
chore/common-parser-root-check
branch
from
095bb32
to
a5e6e57
Compare
Presently there is an approach implemented for JSON5, while other parsers have a TODO comment. I adapted the approach used for the Dhall config support and leveraged it as a common method for
ValueKind.AFAIK, the initial parser call for the
textvalue into afrom_*method will handle any earlier failure, while this ensures thatparse()returns the expected map fromValueKind::Table. I think this satisfies the TODO?