Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file_cache #174

Open
nrc opened this issue Feb 6, 2018 · 1 comment
Open

Refactor file_cache #174

nrc opened this issue Feb 6, 2018 · 1 comment
Labels
L-rust mostly a Rust (or backend) issue

Comments

@nrc
Copy link
Member

nrc commented Feb 6, 2018

It does way too much! It orchestrates indexing and rendering of pages as well as caching pages, plus a bunch of utility things. It should be broken up into at least a couple of modules.
@nkanderson
Copy link
Contributor

Refactor started in 8d9acda, which creates a file_controller module to begin breaking up functionality.

Additional refactoring could include:

  • Moving the Cache into another sub-module of file_controller
  • Moving management of the analysis info (doing searches & lookups via rls-analysis) elsewhere

@nrc nrc added the L-rust mostly a Rust (or backend) issue label May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L-rust mostly a Rust (or backend) issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrc @nkanderson