Support unaligned reads in RmwNorFlashStorage::read #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
I also included some small tests.
One could most definitely choose to use the same method as in
RmwNorFlashStorage::write
of splitting the range into many small blocks, but I've found in my project that small reads are quite detrimental when the flash instructions have to transit over some channel, like SPI.In my project, I went with a similar solution of doing two small reads at the head and at the tail of the requested range, and then one big read for the main body, amortizing the runtime cost of individual reads.
I wasn't sure if the
read
inRmwNorFlashStorage::write
was unaligned, but if it happens to be unaligned, then the subsequent calls toerase
/write
would fail anyway.