-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve regress #728
improve regress #728
Conversation
Nice! |
we need to add retry for curl |
78a8f10
to
1ae4393
Compare
added |
664f976
to
2c1a1ed
Compare
478b2ca
to
40686c1
Compare
What status of this? |
I still want to implement it, just don't have the time or motivation right now |
3946ef9
to
b86edd5
Compare
Header text Diff result (click to expand)diff --git "a/.\\output\\head\\atmel_at91sam9cn11\\/src/lib.rs" "b/.\\output\\base\\atmel_at91sam9cn11\\/src/lib.rs"
index 4fe602c..b31966b 100644
--- "a/.\\output\\head\\atmel_at91sam9cn11\\/src/lib.rs"
+++ "b/.\\output\\base\\atmel_at91sam9cn11\\/src/lib.rs"
@@ -1,4 +1,4 @@
-/*!Peripheral access API for AT91SAM9CN11 microcontrollers (generated using svd2rust v0.31.2 (99e68c7 2023-11-29))
+/*!Peripheral access API for AT91SAM9CN11 microcontrollers (generated using svd2rust v0.31.2 (ef9b813 2023-11-29))
You can find an overview of the generated API [here]. |
it's now possible to do
etc. i have one problem with this though, the diff is way to large to be always useful. I think it would be helpful to have a very small default example case that is expected to only emit few changes. Maybe we could even make a query somehow to specify something like "I only want the diff inside |
This comment was marked as resolved.
This comment was marked as resolved.
switched to yaml! |
Need someone more powerful. cc @therealprof @adamgreig |
@Emilgardis I've made several fixes. See #782 |
.github/workflows/diff.yml
Outdated
summary: | ||
runs-on: ubuntu-latest | ||
needs: [diff] | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to check that generate.outputs.diffs was not empty, otherwise a comment will always be done: Emilgardis#1 (comment)
Maybe it is better to merge this PR and make future changes in new PRs? |
I think that's fine, I'll cleanup the commits and do the last adjustments before a review to merge |
0089838
to
aefd610
Compare
2bd35fc
to
b366167
Compare
managed to sneak in a bug during the rebase and implementing |
7245a5d
to
f9f22d0
Compare
f9f22d0
to
eb0c405
Compare
🥳 |
/ci diff pr lets try it :) |
well it works, but it doesn't like the command , will fix |
Beginning of revamp for our CI
This pr adds the following new features
svd2rust-regress tests -- --command
cargo regress
->cargo run -p svd2rust-regress --
This allows for diffing between svd2rust versions and command inputs
@pr
= version from current pr,@master
= version from master branchon_comment
hook to allow diffing prs<details>
or gistresolves #355