Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect mapping of ZeroToSet #826

Closed
BigPeteB opened this issue Mar 19, 2024 · 1 comment
Closed

Incorrect mapping of ZeroToSet #826

BigPeteB opened this issue Mar 19, 2024 · 1 comment

Comments

@BigPeteB
Copy link
Contributor

It looks like the fix in #673 has a bug. At https://github.com/rust-embedded/svd2rust/blame/6de189fc83268cfd5f66377c65a5aa2430de9e74/src/generate/register.rs#L858, ZeroToSet maps to "BitWriter0C". Should this not be "BitWriter0S"?
@burrbull
Copy link
Member

Yes. It's a typo.
It is strange nobody's found this yet.
Open PR, please.

@BigPeteB BigPeteB mentioned this issue Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burrbull @BigPeteB