-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RFC: Exhaustive traits. Traits that enable cross trait casting between trait objects. #3885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…haustive' trait is static edited comment to be less vague
|
We could avoid Rule 1 by building the vtable lookup table externally in As |
|
I made another RFC: #3888. If that lands, rather than having every trait object being forced to store metadata for casting, there could be a trait Castable: 'static {
const self EXHAUSTABLE_IMPLEMENTATIONS: &'static [(TypeId, TraitVTable)];
}which could have a blanket implementation of: impl<T: 'static> Castable for T {
const self EXHAUSTABLE_IMPLEMENTATIONS: &'static [(TypeId, TraitVTable)] = std::intrinsics::exhausive_implementations::<T>();
}Which would make the metadata for casting opt in Though this will require a good chunk of changes to the It would be ideal to make this Of course we can do compiler magic, and make the |
|
To me "exhaustive" suggests that the trait can only be implemented within the defining crate (like sealed). I'm not really sure what a better name is though. |
|
@tmccombs I would use a better name than |
|
Appears intertrait already provides a much cleaner solution, by using the linkme. At present linkme needs linker support, but one could bypass the linker, using only |
|
@burdges i tried I also tried out
|
|
Interesting thanks. Appears 4 years since their last version, and the owning blockchain has no updates since May 2023, so bitrot. It nevertheless shows that rule 1 maybe excessively restrictive. Anyways I definitely agree that generic statics or similar ala #3888 sound useful. |
I agree, but I cannot find a way around this due to how separate compilation works. I would gladly remove that rule if it were soundly possible |
|
Is it possible for sidecasting from trait A to trait B to make a subtrait of both, downcast to that subtrait, then upcast to B? I don't think it's that farfetched but I only have vague surface level of the compiler so I don't really know. I just figured I should make sure it's considered. |
|
Yes, but only for types defined downstream of both traits, by Rule 1. If you have a &dyn A coming from a &u64 under the hood, then you cannot cast it to a &dyn B. And Box was not directly addressed.
There are degrees of separate compilation here: We've large projects using codegen-units=1 for various reasons, by far the worst failure of separate compilation, but really quite standard. By comparison, intertrait only needs some append only structure that's compiled late. Imho intertrait does not go far enough, and should reprocess those append only structures into efficently indexable families. Around this, I wonder if intertrait failed because it depends upon lto or another linker flag? Anyways, all these crates for casting dyn Trait track the vtables for the different pointer types seperately. As they check the underlying type, their reason for doing would be unstability of the Pointer layout, aka soundness bitrot. I'd suggest two preliminary changes: First, Rust should commit to all smart pointer types using the same vtables. This is probably already the case. Second, Rust should exposes unsafe methods that manipulate the vtable pointer, optionally safe ones too. This would prevent soundness bitrot in external crates that cast dyn Traits, and allow wider adoption. |
This RFC proposes #[exhaustive] traits to enable sound cross-trait casting for trait objects.
For any concrete type T, the set of #[exhaustive] traits it implements is finite and deterministic, allowing runtime checks like “if this dyn A also implements dyn B, cast and use it.”
The design adds a per-type exhaustive trait→vtable map and enforces four rules (type-crate ownership of implementation, trait arguments determined by Self, object safe, and 'static only) to keep the mapping coherent under separate compilation.
Use cases include capability-based game entities (e.g., Damageable, Walkable traits) and GUI widgets (e.g., Clickable, Scrollable),
avoiding manual registry/macro approaches such as bevy_reflect.
This enables patterns such as: "if dyn Character is dyn Flyable, then character.fly()"
Rendered