Fix warnings.

Author: reitermarkus

bindgen/clang.rs

@@ -1839,10 +1839,7 @@ impl Index {
     pub(crate) fn new(pch: bool, diag: bool) -> Index {
         unsafe {
             Index {
-                x: clang_createIndex(
-                    pch.try_into().unwrap(),
-                    diag.try_into().unwrap(),
-                ),
+                x: clang_createIndex(pch.into(), diag.into()),
             }
         }
     }
@@ -1917,7 +1914,7 @@ impl TranslationUnit {
             let mut diags = vec![];
             for i in 0..num {
                 diags.push(Diagnostic {
-                    x: clang_getDiagnostic(self.x, i.try_into().unwrap()),
+                    x: clang_getDiagnostic(self.x, i),
                 });
             }
             diags
@@ -2324,10 +2321,12 @@ impl EvalResult {
 
         if unsafe { clang_EvalResult_isUnsignedInt(self.x) } != 0 {
             let value = unsafe { clang_EvalResult_getAsUnsigned(self.x) };
+            #[allow(clippy::unnecessary_fallible_conversions)]
             return i128::try_from(value).ok();
         }
 
         let value = unsafe { clang_EvalResult_getAsLongLong(self.x) };
+        #[allow(clippy::unnecessary_fallible_conversions)]
         i128::try_from(value).ok()
     }
 

bindgen/codegen/macro_def.rs

@@ -117,7 +117,7 @@ impl CodeGenerator for MacroDef {
                 }
                 result.saw_var_macro(name);
 
-                let canonical_ident = ctx.rust_ident(&canonical_name);
+                let canonical_ident = ctx.rust_ident(canonical_name);
 
                 let mut var_macro = match ctx.macro_set.expand_var_macro(name) {
                     Ok(body) => match VarMacro::parse(name, &body) {

bindgen/ir/comp.rs

@@ -592,7 +592,7 @@ where
     const is_ms_struct: bool = false;
 
     for bitfield in raw_bitfields {
-        let bitfield_width = bitfield.bitfield_width().unwrap() as usize;
+        let bitfield_width = bitfield.bitfield_width().unwrap();
         let bitfield_layout =
             ctx.resolve_type(bitfield.ty()).layout(ctx).ok_or(())?;
         let bitfield_size = bitfield_layout.size;