From 8bd6cfe761cfba5c7e8e993a646cc4d929d08a73 Mon Sep 17 00:00:00 2001 From: Mattias Wallin Date: Sun, 15 Sep 2024 12:07:07 +0200 Subject: [PATCH] Non-panicking Display for Path --- src/bin/main.rs | 4 ++-- src/config/file_lines.rs | 2 +- src/test/mod.rs | 12 ++++-------- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/bin/main.rs b/src/bin/main.rs index 0d593c6c416..c7d3a060d54 100644 --- a/src/bin/main.rs +++ b/src/bin/main.rs @@ -341,10 +341,10 @@ fn format( for file in files { if !file.exists() { - eprintln!("Error: file `{}` does not exist", file.to_str().unwrap()); + eprintln!("Error: file `{}` does not exist", file.display()); session.add_operational_error(); } else if file.is_dir() { - eprintln!("Error: `{}` is a directory", file.to_str().unwrap()); + eprintln!("Error: `{}` is a directory", file.display()); session.add_operational_error(); } else { // Check the file directory if the config-path could not be read or not provided diff --git a/src/config/file_lines.rs b/src/config/file_lines.rs index 7f32765195d..c53ec6371e9 100644 --- a/src/config/file_lines.rs +++ b/src/config/file_lines.rs @@ -38,7 +38,7 @@ impl From for FileName { impl fmt::Display for FileName { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { - FileName::Real(p) => write!(f, "{}", p.to_str().unwrap()), + FileName::Real(p) => write!(f, "{}", p.display()), FileName::Stdin => write!(f, ""), } } diff --git a/src/test/mod.rs b/src/test/mod.rs index 28f95ee54e5..d62da08fff8 100644 --- a/src/test/mod.rs +++ b/src/test/mod.rs @@ -105,10 +105,9 @@ fn is_file_skip(path: &Path) -> bool { fn get_test_files(path: &Path, recursive: bool) -> Vec { let mut files = vec![]; if path.is_dir() { - for entry in fs::read_dir(path).expect(&format!( - "couldn't read directory {}", - path.to_str().unwrap() - )) { + for entry in + fs::read_dir(path).expect(&format!("couldn't read directory {}", path.display())) + { let entry = entry.expect("couldn't get `DirEntry`"); let path = entry.path(); if path.is_dir() && recursive { @@ -122,10 +121,7 @@ fn get_test_files(path: &Path, recursive: bool) -> Vec { } fn verify_config_used(path: &Path, config_name: &str) { - for entry in fs::read_dir(path).expect(&format!( - "couldn't read {} directory", - path.to_str().unwrap() - )) { + for entry in fs::read_dir(path).expect(&format!("couldn't read {} directory", path.display())) { let entry = entry.expect("couldn't get directory entry"); let path = entry.path(); if path.extension().map_or(false, |f| f == "rs") {