Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Limit the range of valid toolchain names, take caution in rust-toolchain.toml #4059

Open
1 task done
rami3l opened this issue Oct 23, 2024 · 0 comments
Open
1 task done

Tracking: Limit the range of valid toolchain names, take caution in rust-toolchain.toml #4059

rami3l opened this issue Oct 23, 2024 · 0 comments
Labels
tracking This is a tracking issue
Milestone
1.29.0

Comments

@rami3l
Copy link
Member

rami3l commented Oct 23, 2024 •
edited
Loading

As discussed in #4053 (comment), there are basically two issues to address:

  1. Improve current error messages and treat toolchain names coming from rust-toolchain.toml as untrusted.
  2. Come up with more restrictive rules in respect to legal toolchain names.
    a. If the rules allow the prevention of phishing, lift the restriction on displaying toolchain names from rust-toolchain.toml if they are legal.

Tasks
@rami3l rami3l added the tracking This is a tracking issue label Oct 23, 2024
@rami3l rami3l added this to the 1.29.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracking This is a tracking issue
Projects
None yet
Milestone
1.29.0
Development

No branches or pull requests
1 participant
@rami3l