Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive CI coverage #49

Open
ian-h-chamberlain opened this issue Nov 24, 2023 · 1 comment
Open

More comprehensive CI coverage #49

ian-h-chamberlain opened this issue Nov 24, 2023 · 1 comment

Comments

@ian-h-chamberlain
Copy link
Member

Right now, the CI only does two basic functionality checks of the tool:

      - name: Create new project
        run: cargo 3ds new app --bin

      - name: Build project
        working-directory: ./app
        run: cargo 3ds build --release

We could add more unit tests, integration tests, etc., but it would probably be a good idea to just run through some of the different uses cases that are supported. Offhand these are the ones that I can think of:

  • cargo 3ds build maybe with a couple of other argument combinations
  • cargo 3ds test (with and without --no-run)
    • --lib
    • --doc
    • --test ?
    • --example? is that supported?
  • cargo 3ds run
    • --bin
    • --example
  • cargo 3ds doc, I guess? Maybe also other passthrough commands like check, clippy, etc.

We'd probably need to use custom runners or a custom 3dslink wrapper script to really test everything properly.

Also would be nice to test on different platforms, but the lack of devkitPro toolchain images will probably make it hard to test the whole process. We should bbe able to at least test cargo 3ds new and maybe cargo 3ds check?

@Meziu
Copy link
Member

Meziu commented Nov 25, 2023

When those simple tests were added ther was no way to run code in the CI. I guess we should expand the suite now that we can 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants