Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize description, icon etc. per-target instead of per-package #62

Open
ian-h-chamberlain opened this issue Jun 15, 2024 · 0 comments
Assignees

Comments

@ian-h-chamberlain
Copy link
Member

With #60 the groundwork will be laid out to parse TOML for each artifact, to customize icon, description etc. for multiple executables. For now it just uses the package-level metadata, but as mentioned in #44 it would be nice to customize them separately too.

This issue is just broken out so I can do a separate PR. Reposting the example:

[[example]]
name = "ex1"
# I think "description" is non-standard here as it's not documented in
# https://doc.rust-lang.org/cargo/reference/cargo-targets.html#configuring-a-target 
# We could still look for it, but we'd have to manually read in from Cargo.toml 

# examples/ex2.rs may exist but not be defined explicitly in Cargo.toml

[[bin]]
name = "mybin"

# etc. for tests, benches if need be

[package.metadata.cargo-3ds]
romfs_dir = "examples/romfs" # still optional

# should we call these "example", "bin" etc. to match the top-level key?
examples.ex1.romfs_dir = "examples/ex1_romfs"
examples.ex2.romfs_dir = "examples/ex2_romfs"

tests.integration.romfs_dir = "tests/romfs"

# mybin falls back to using "examples/romfs"

# if we needed something else for lib tests we could also do something like this
# but probably it should just use the top level one if we can manage that
lib.romfs_dir = "..."
@ian-h-chamberlain ian-h-chamberlain self-assigned this Jun 15, 2024
@ian-h-chamberlain ian-h-chamberlain changed the title Customize descript, icon etc. per-target instead of per-package Customize description, icon etc. per-target instead of per-package Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant