Hardcoded value for region when creating new bucket.

[kielstr]

I've been hitting this error when using V4 auth and creating buckets.

AuthorizationHeaderMalformed: The authorization header is malformed; the region is wrong; expecting 'us-east-1'. at .../net-amazon-s3/lib/Net/Amazon/S3/Client.pm line 97.
	Net::Amazon::S3::Client::_send_request(Net::Amazon::S3::Client=HASH(0x7fcc28006e38), HTTP::Request=HASH(0x7fcbf196f140)) called at .../net-amazon-s3/lib/Net/Amazon/S3/Client/Bucket.pm line 36
	Net::Amazon::S3::Client::Bucket::_create(Net::Amazon::S3::Client::Bucket=HASH(0x7fcc28006e08), "acl_short", "private", "location_constraint", "ap-southeast-2") called at .../net-amazon-s3/lib/Net/Amazon/S3/Client.pm line 63
	Net::Amazon::S3::Client::create_bucket(Net::Amazon::S3::Client=HASH(0x7fcc28006e38), "name", "testing", "acl_short", "private", "location_constraint", "ap-southeast-2") called at bin/create-bucket-location.pl line 37

Backend is MinIO which has been configured to use ap-southeast-2. I can see it setting the header X-Amz-Bucket-Region to ap-southeast-2 However calling $client->create_bucket fails with the above error.

Seems to be due to the hardcoded value in Net::Amazon::S3::Request::CreateBucket->http_request

net-amazon-s3/lib/Net/Amazon/S3/Request/CreateBucket.pm

Line 33 in d9fe34f

region => 'us-east-1',

Happy to create a PR to remove region =>'us-east-1' or discuss further the issue.

[happy-barney]

Hi @kielstr
thanks for reporting this.

Sorry for trouble, at time of writing I had access only to Amazon's S3 and I just followed their documentation.

Recognizing additional headers in this request may not be bad idea but hardcoded default value should remain.

Implementation wise I'd prefer Net::Amazon::S3 property bucket_create_region with default value us-east-1.

   region => $self->s3->create_bucket_region,

[kielstr]

Makes sense to me.

Would it be better to call the attribute region ? This would facilitate sharing of the resource.

[happy-barney]

region may imply also region for already created buckets (_head_region) as well as restriction
create_bucket_region on other hand may imply default value of location constraint.

create_bucket_request_region may be little bit more explicit, to represent region, where create bucket request is sent to.

This parameter is specific, it represents Amazon's behaviour (as far as I understand related Note on CreateBucket documentation). It is vendor specific, similar to default value of authorization_method.

That may be also interesting idea, Net::Amazon::S3::Vendor:: namespace with region_from_hostname functionality (that's in fact what is needed here)