Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed paths via stdin #27

Closed
jzbor opened this issue Oct 6, 2024 · 2 comments
Closed

Feed paths via stdin #27

jzbor opened this issue Oct 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jzbor
Copy link

jzbor commented Oct 6, 2024

It is now possible to feed attic paths via stdin: zhaofengli/attic#176

This way it is no longer to chunk the paths when pushing (

const splitAddedPaths = splitArray(addedPaths, 25);
).
This should significantly speed up the action.

@ryanccn ryanccn added enhancement New feature or request blocked labels Oct 6, 2024
@ryanccn
Copy link
Owner

ryanccn commented Oct 6, 2024

This is blocked until Nixpkgs' attic-client is updated to include this feature, since it is not feasible to build attic from source on every CI run.

@jzbor
Copy link
Author

jzbor commented Oct 6, 2024

Alright! Seems like the corresponding PR is already on master, so it should not be too long: NixOS/nixpkgs#346503

EDIT: Should be in the binary cache now: https://nixpkgs-tracker.ocfox.me/?pr=346503

@ryanccn ryanccn removed the blocked label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants