From 75d574fca84b1dae3b39dfa82f24381fe46f2004 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Fri, 18 Aug 2023 12:06:11 -0700 Subject: [PATCH 1/3] Stop passing a nullable value to Completer.completer. --- just_audio/lib/just_audio.dart | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/just_audio/lib/just_audio.dart b/just_audio/lib/just_audio.dart index b3595824..61b275bf 100644 --- a/just_audio/lib/just_audio.dart +++ b/just_audio/lib/just_audio.dart @@ -3756,7 +3756,6 @@ class AndroidEqualizerParameters { /// An [AudioEffect] for Android that can adjust the gain for different /// frequency bands of an [AudioPlayer]'s audio signal. class AndroidEqualizer extends AudioEffect with AndroidAudioEffect { - AndroidEqualizerParameters? _parameters; final Completer _parametersCompleter = Completer(); @@ -3772,9 +3771,9 @@ class AndroidEqualizer extends AudioEffect with AndroidAudioEffect { } final response = await platform .androidEqualizerGetParameters(AndroidEqualizerGetParametersRequest()); - _parameters = + final parameters = AndroidEqualizerParameters._fromMessage(_player!, response.parameters); - _parametersCompleter.complete(_parameters); + _parametersCompleter.complete(parameters); } /// The parameter values of this equalizer. From 08a83c1480cba4763c9b82562965ea2f3a3fe6ef Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Sun, 20 Aug 2023 20:41:36 -0700 Subject: [PATCH 2/3] Address feedback --- just_audio/lib/just_audio.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/just_audio/lib/just_audio.dart b/just_audio/lib/just_audio.dart index 61b275bf..60cb5e67 100644 --- a/just_audio/lib/just_audio.dart +++ b/just_audio/lib/just_audio.dart @@ -3771,9 +3771,9 @@ class AndroidEqualizer extends AudioEffect with AndroidAudioEffect { } final response = await platform .androidEqualizerGetParameters(AndroidEqualizerGetParametersRequest()); - final parameters = + final receivedParameters = AndroidEqualizerParameters._fromMessage(_player!, response.parameters); - _parametersCompleter.complete(parameters); + _parametersCompleter.complete(receivedParameters); } /// The parameter values of this equalizer. From c341b6c9e41c009ff1199bd2d3785f357310bd11 Mon Sep 17 00:00:00 2001 From: Ryan Heise Date: Tue, 22 Aug 2023 00:27:06 +1000 Subject: [PATCH 3/3] Bump version to 0.9.35 --- just_audio/CHANGELOG.md | 4 ++++ just_audio/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/just_audio/CHANGELOG.md b/just_audio/CHANGELOG.md index 735220e1..876bb6a4 100644 --- a/just_audio/CHANGELOG.md +++ b/just_audio/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.9.35 + +* Fix nullable completer argument type (@srawlins). + ## 0.9.34 * Support AGP 8 (@josephcrowell). diff --git a/just_audio/pubspec.yaml b/just_audio/pubspec.yaml index bbab38ff..e2542834 100644 --- a/just_audio/pubspec.yaml +++ b/just_audio/pubspec.yaml @@ -1,6 +1,6 @@ name: just_audio description: A feature-rich audio player for Flutter. Loop, clip and concatenate any sound from any source (asset/file/URL/stream) in a variety of audio formats with gapless playback. -version: 0.9.34 +version: 0.9.35 repository: https://github.com/ryanheise/just_audio/tree/minor/just_audio issue_tracker: https://github.com/ryanheise/just_audio/issues topics: