Skip to content

Commit 8646f25

Browse files
committed
Split test helper module
1 parent b2df3ab commit 8646f25

38 files changed

+48
-46
lines changed

src/test/acceptance/features/highlight-selected-text.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {verify, wrapVerify} from '../../helpers/helper';
1+
import {verify, wrapVerify} from '../../helpers/mock';
22

33
import AppIntegrator from '../../../lib/app-integrator';
44
import {createFakeEditor} from '../helpers/fake-editor';

src/test/acceptance/helpers/fake-editor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockMethods} from '../../helpers/helper';
1+
import {mockMethods} from '../../helpers/mock';
22
import * as vscode from 'vscode';
33
import {Position, Selection} from 'vscode';
44

src/test/acceptance/helpers/fake-vscode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {stubReturns} from '../../helpers/helper';
1+
import {stubReturns} from '../../helpers/mock';
22
import {Range} from 'vscode';
33

44
export const createFakeVsCode = ({editors}: any = {}) => {

src/test/helpers/assertions.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import * as assert from 'assert';
2+
3+
export const assertKeyExists = (obj: object, key: string) => {
4+
assert.ok(obj.hasOwnProperty(key), `Key (${key}) does not exist in the object`);
5+
};
6+
7+
export function assertInstanceOf<T>(obj: any, c: new (...args: any[]) => T) {
8+
assert.ok(obj instanceof c, `Object is not an instance of ${c.name}`);
9+
}

src/test/helpers/helper.ts renamed to src/test/helpers/mock.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@ export const when = td.when;
77

88
export const verify = td.verify;
99

10-
export const assertKeyExists = (obj: object, key: string) => {
11-
assert.ok(obj.hasOwnProperty(key), `Key (${key}) does not exist in the object`);
12-
};
13-
14-
export function assertInstanceOf<T>(obj: any, c: new (...args: any[]) => T) {
15-
assert.ok(obj instanceof c, `Object is not an instance of ${c.name}`);
16-
}
17-
1810
export function wrapVerify(invokeCallback: (...args: any[]) => void, expectedCalls: any[][] | {[key: string]: any[]}) {
1911
const captors = [td.matchers.captor(), td.matchers.captor(), td.matchers.captor()];
2012

src/test/stub-vscode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const mockVscode = {
88
StatusBarAlignment: {Right: 2},
99
TextEditorRevealType: {InCenterIfOutsideViewport: 2},
1010
Position: function (line: number, character: number) {
11-
return {line, character};
11+
return {line, character} as Position;
1212
},
1313
Selection: function (start: Position, end: Position) {
1414
return {start, end} as Selection;

src/test/unit/colour-registry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockType} from '../helpers/helper';
1+
import {mockType} from '../helpers/mock';
22

33
import ColourRegistry from '../../lib/colour-registry';
44
import ConfigStore from '../../lib/config-store';

src/test/unit/command-wrapper.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {contains, mockMethods, mockType, verify} from '../helpers/helper';
1+
import {contains, mockMethods, mockType, verify} from '../helpers/mock';
22

33
import CommandWrapper from '../../lib/command-wrapper';
44
import {Logger} from '../../lib/Logger';

src/test/unit/commands/auto-refresh-decoration-with-delay.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, callback, contains, mock, mockMethods, mockType, verify, when} from '../../helpers/helper';
1+
import {any, callback, contains, mock, mockMethods, mockType, verify, when} from '../../helpers/mock';
22

33
import WindowComponent from '../../../lib/editor-components/window';
44
import Debouncer from '../../../lib/debouncer';

src/test/unit/commands/auto-refresh-decoration.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify, when} from '../../helpers/helper';
1+
import {mock, verify, when} from '../../helpers/mock';
22
import DecorationOperatorFactory from '../../../lib/decoration-operator-factory';
33
import TextEditor from '../../../lib/text-editor';
44
import DecorationOperator from '../../../lib/decoration-operator';

src/test/unit/commands/go-to-next-highlight.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import TextEditor from '../../../lib/text-editor';
2-
import {mock, mockMethods, mockType, verify, when} from '../../helpers/helper';
2+
import {mock, mockMethods, mockType, verify, when} from '../../helpers/mock';
33
import TextLocationRegistry from '../../../lib/text-location-registry';
44
import {GoToNextHighlightCommand} from '../../../lib/commands/go-to-next-highlight';
55
import MatchingModeRegistry from '../../../lib/matching-mode-registry';

src/test/unit/commands/go-to-previous-highlight.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import TextEditor from '../../../lib/text-editor';
2-
import {mock, mockMethods, mockType, verify, when} from '../../helpers/helper';
2+
import {mock, mockMethods, mockType, verify, when} from '../../helpers/mock';
33
import TextLocationRegistry from '../../../lib/text-location-registry';
44
import MatchingModeRegistry from '../../../lib/matching-mode-registry';
55
import StringPattern from '../../../lib/patterns/string';

src/test/unit/commands/highlight-using-regex.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, when, verify} from '../../helpers/helper';
1+
import {mock, when, verify} from '../../helpers/mock';
22
import HighlightUsingRegexCommand from '../../../lib/commands/highlight-using-regex';
33
import DecorationOperatorFactory from '../../../lib/decoration-operator-factory';
44
import RegexReader from '../../../lib/regex-reader';

src/test/unit/commands/remove-all-highlights.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify, when} from '../../helpers/helper';
1+
import {mock, verify, when} from '../../helpers/mock';
22
import RemoveAllHighlightsCommand from '../../../lib/commands/remove-all-highlights';
33
import DecorationOperatorFactory from '../../../lib/decoration-operator-factory';
44
import DecorationOperator from '../../../lib/decoration-operator';

src/test/unit/commands/save-all-highlights.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify, when} from '../../helpers/helper';
1+
import {mock, verify, when} from '../../helpers/mock';
22
import SaveAllHighlightsCommand from '../../../lib/commands/save-all-highlights';
33
import DecorationRegistry from '../../../lib/decoration-registry';
44
import ConfigStore from '../../../lib/config-store';

src/test/unit/commands/toggle-case-sensitivity-mode.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify} from '../../helpers/helper';
1+
import {mock, verify} from '../../helpers/mock';
22

33
import ToggleCaseSensitivityModeCommand from '../../../lib/commands/toggle-case-sensitivity-mode';
44
import MatchingModeRegistry from '../../../lib/matching-mode-registry';

src/test/unit/commands/toggle-case-sensitivity.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify, when} from '../../helpers/helper';
1+
import {mock, verify, when} from '../../helpers/mock';
22
import {PatternAction} from '../../../lib/const';
33
import ToggleCaseSensitivityCommand from '../../../lib/commands/toggle-case-sensitivity';
44
import HighlightPatternPicker from '../../../lib/highlight-pattern-picker';

src/test/unit/commands/toggle-highlight.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, mockMethods, mockType, verify, when} from '../../helpers/helper';
1+
import {any, mock, mockMethods, mockType, verify, when} from '../../helpers/mock';
22

33
import ToggleHighlightCommand from '../../../lib/commands/toggle-highlight';
44
import TextEditor from '../../../lib/text-editor';

src/test/unit/commands/toggle-whole-match-mode.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, verify} from '../../helpers/helper';
1+
import {mock, verify} from '../../helpers/mock';
22

33
import ToggleWholeMatchModeCommand from '../../../lib/commands/toggle-whole-match-mode';
44
import MatchingModeRegistry from '../../../lib/matching-mode-registry';

src/test/unit/commands/toggle-whole-match.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, verify, when} from '../../helpers/helper';
1+
import {any, mock, verify, when} from '../../helpers/mock';
22

33
import {PatternAction} from '../../../lib/const';
44
import ToggleWholeMatchCommand from '../../../lib/commands/toggle-whole-match';

src/test/unit/commands/unhighlight.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, verify, when} from '../../helpers/helper';
1+
import {any, mock, verify, when} from '../../helpers/mock';
22

33
import UnhighlightCommand from '../../../lib/commands/unhighlight';
44
import DecorationOperatorFactory from '../../../lib/decoration-operator-factory';

src/test/unit/commands/update-highlight.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, mockType, verify, when} from '../../helpers/helper';
1+
import {any, mock, mockType, verify, when} from '../../helpers/mock';
22

33
import UpdateHighlightCommand from '../../../lib/commands/update-highlight';
44
import DecorationOperatorFactory from '../../../lib/decoration-operator-factory';

src/test/unit/config-store.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, mockMethods, verify, when} from '../helpers/helper';
1+
import {mock, mockMethods, verify, when} from '../helpers/mock';
22

33
import ConfigStore from '../../lib/config-store';
44
import * as vscode from 'vscode';

src/test/unit/config-target-picker.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, when} from '../helpers/helper';
1+
import {any, mock, when} from '../helpers/mock';
22

33
import ConfigTargetPicker from '../../lib/config-target-picker';
44
import WindowComponent from '../../lib/editor-components/window';

src/test/unit/debouncer.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockFunction, mockType, verify} from '../helpers/helper';
1+
import {mockFunction, mockType, verify} from '../helpers/mock';
22

33
import Debouncer from '../../lib/debouncer';
44
import ConfigStore from '../../lib/config-store';

src/test/unit/decoration-operator.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, mockType, verify, when, wrapVerify} from '../helpers/helper';
1+
import {any, mock, mockType, verify, when, wrapVerify} from '../helpers/mock';
22

33
import DecorationOperator from '../../lib/decoration-operator';
44
import PatternConverter from '../../lib/pattern-converter';

src/test/unit/decoration-registry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockMethods, mockType, stubReturns, when} from '../helpers/helper';
1+
import {mockMethods, mockType, stubReturns, when} from '../helpers/mock';
22

33
import DecorationRegistry from '../../lib/decoration-registry';
44
import PatternFactory from '../../lib/pattern-factory';

src/test/unit/highlight-pattern-picker.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {any, mock, mockType, verify, when} from '../helpers/helper';
1+
import {any, mock, mockType, verify, when} from '../helpers/mock';
22

33
import HighlightPatternPicker from '../../lib/highlight-pattern-picker';
44
import PatternFactory from '../../lib/pattern-factory';

src/test/unit/matching-mode-registry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {assertKeyExists} from '../helpers/helper';
1+
import {assertKeyExists} from '../helpers/assertions';
22
import {Event} from '../../lib/const';
33
import MatchingModeRegistry from '../../lib/matching-mode-registry';
44
import {EventEmitter} from 'events';

src/test/unit/pattern-factory.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
import {assertInstanceOf, mockType} from '../helpers/helper';
1+
import {mockType} from '../helpers/mock';
22

33
import PatternFactory from '../../lib/pattern-factory';
44
import StringPattern from '../../lib/patterns/string';
55
import RegexPattern from '../../lib/patterns/regex';
66
import MatchingModeRegistry from '../../lib/matching-mode-registry';
77
import * as assert from 'assert';
8+
import {assertInstanceOf} from '../helpers/assertions';
89

910
suite('PatternFactory', () => {
1011

src/test/unit/pattern-variation-reader.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockType} from '../helpers/helper';
1+
import {mockType} from '../helpers/mock';
22

33
import PatternVariationReader from '../../lib/pattern-variation-reader';
44
import PatternFactory from '../../lib/pattern-factory';

src/test/unit/regex-reader.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, mockType, when} from '../helpers/helper';
1+
import {mock, mockType, when} from '../helpers/mock';
22

33
import RegexReader from '../../lib/regex-reader';
44
import WindowComponent from '../../lib/editor-components/window';

src/test/unit/saved-highlights-restorer.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, mockType, verify, when} from '../helpers/helper';
1+
import {mock, mockType, verify, when} from '../helpers/mock';
22
import {Event} from '../../lib/const';
33
import SavedHighlightsRestorer from '../../lib/saved-highlights-restorer';
44
import ConfigStore from '../../lib/config-store';

src/test/unit/selected-text-finder.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockType} from '../helpers/helper';
1+
import {mockType} from '../helpers/mock';
22

33
import SelectedTextFinder from '../../lib/selected-text-finder';
44
import * as vscode from 'vscode';

src/test/unit/statusbar-buttons/toggle-case-sensitivity-mode.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockMethods, verify} from '../../helpers/helper';
1+
import {mockMethods, verify} from '../../helpers/mock';
22
import {Event} from '../../../lib/const';
33
import ToggleCaseSensitivityModeButton from '../../../lib/statusbar-buttons/toggle-case-sensitivity-mode';
44
import {StatusBarItem} from 'vscode';

src/test/unit/statusbar-buttons/toggle-whole-match-mode.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mockMethods, verify} from '../../helpers/helper';
1+
import {mockMethods, verify} from '../../helpers/mock';
22
import {Event} from '../../../lib/const';
33
import ToggleWholeMatchModeButton from '../../../lib/statusbar-buttons/toggle-whole-match-mode';
44
import {StatusBarItem} from 'vscode';

src/test/unit/text-decorator.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {mock, mockMethods, mockType, verify, wrapVerify} from '../helpers/helper';
1+
import {mock, mockMethods, mockType, verify, wrapVerify} from '../helpers/mock';
22

33
import TextDecorator from '../../lib/text-decorator';
44
import PatternFactory from '../../lib/pattern-factory';

src/test/unit/text-editor.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import TextEditor from '../../lib/text-editor';
22
import {Position, Range, Selection, TextDocument, TextEditor as VsTextEditor, TextEditorRevealType} from 'vscode';
3-
import {mockMethods, verify, when} from '../helpers/helper';
3+
import {mockMethods, verify, when} from '../helpers/mock';
44
import * as assert from 'assert';
55

66
suite('TextEditor', () => {
@@ -17,8 +17,8 @@ suite('TextEditor', () => {
1717

1818
test('reveals the area if the given cursor position is out of visible area', () => {
1919
editor.selection = {start: 0, end: 5};
20-
assert.deepEqual(rawEditor.selection, range(position1, position2));
21-
verify(rawEditor.revealRange(selection(position1, position2), TextEditorRevealType.InCenterIfOutsideViewport));
20+
assert.deepEqual(rawEditor.selection, selection(position1, position2));
21+
verify(rawEditor.revealRange(range(position1, position2), TextEditorRevealType.InCenterIfOutsideViewport));
2222
});
2323

2424
function position(line: number, character: number): Position {

0 commit comments

Comments
 (0)