Skip to content

Code Review Comments (Jose Espinoza) #10

@joseespinoza15432

Description

@joseespinoza15432
  1. Add try except blocks to handle sql errors
  2. Add more documentation in the code itself by use of comments.
  3. Edge cases especially in sql operations so as not to provide unexpected results.
  4. in the chore file, improve the frequencyenum directly to the schema to reduce inconsistencies
  5. Standarize import and usages for better readability / remove unused ones
  6. Change function names for descriptiveness
  7. add/ improve error functions for debugging and readability
  8. In the bill and chore assignment file, you can increase readability by creating functions for repetitive code
  9. Use dictionaries in those same files to reduce clutter and replace if else statements
  10. break functions into smaller functions similar to what we learned in class which helps isolate bugs
  11. Join tables to replace multiple calls where you can in the chore file
  12. Add more statements at the start or end of db operations
  13. add descriptive names to variables to help each other read code
  14. add constants for variables that are goint to be constant like the pending for example

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions