Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a more cautious formulation for what constructors return #19

Open
chillenzer opened this issue Jun 2, 2023 · 1 comment
Open

Comments

@chillenzer
Copy link

"Equality and identity" in Chapter 1 states that "constructing a new object that is the same as an existing one will give a result that is equal, but not identical, to the existing one". This is not quite true in the most general case (despite being a reasonable assumption for practical purposes).

We should find a more cautious formulation for that. One suggestion was to add "by default" to the sentence (although that's still not quite right because the default for int is different for example). Maybe "usually" or just "It is useful to think about it as this although it's a bit more subtle".

@edbennett
Copy link
Member

Ah, I'd forgotten the exact context for the statement. I'd prefer "usually" for brevity and minimal derailing, unless we leave it as-is in the spirit of lies to children

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants