Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--project-name does not work since code skips it due to project-id default 0 #252

Open
focusaurus opened this issue Jan 14, 2024 · 6 comments

Comments

@focusaurus
Copy link

I believe the logic here in add.go always skips the project name lookup since item.ProjectID defaults to "0" not empty string. I changed it to:

if item.ProjectID == "" || item.ProjectID == "0" {

locally and that seemed to fix it for me. Can send a PR if that seems like the correct fix.

@mgsloan
Copy link
Contributor

mgsloan commented Feb 20, 2024

Heya @focusaurus, funny to see you here! I encountered a different issue with add that seems to have been resolved by building from source, but along the way I saw this and opened a PR fixing it

@job-almekinders
Copy link

job-almekinders commented Oct 18, 2024

Hello, what is the status on this issue? For me it doesn't work if I specify the project name. E.g., this doesn't work:

todoist a -N project_name task_name

@focusaurus @mgsloan @sachaos

@mgsloan
Copy link
Contributor

mgsloan commented Oct 18, 2024

@job-almekinders Unfortunately it seems like this isn't being actively maintained. My PR has a fix but it hasn't been merged. You can build it with my patch to get the fix.

@sachaos
Copy link
Owner

sachaos commented Oct 18, 2024

Sorry for that...

@mgsloan
Copy link
Contributor

mgsloan commented Oct 18, 2024

No worries, thanks for making this and sharing it!!! ❤️

@job-almekinders
Copy link

Thanks! @sachaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants