release-mode compilation crashes on swift development toolchains #131
Description
For example, on the 2020-11-18 toolchain, swift build -c release gives:
[1/5] Compiling PenguinTesting StdlibProtocolTests.swift
swift-frontend: /home/build-user/swift/lib/SIL/Utils/MemAccessUtils.cpp:98: void (anonymous namespace)::AccessPhiVisitor<(anonymous namespace)::FindAccessBaseVisitor>::checkVisitorResult(swift::SILValue) [UseDefVisitor = (anonymous namespace)::FindAccessBaseVisitor]: Assertion `!result && "must override any visitor that returns a result"' failed.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0. Program arguments: /usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend -frontend -c /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/AnyArrayBuffer.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/AnyValue.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/ArrayBuffer.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/ArrayStorage.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/CollectionAlgorithms.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Concatenation.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/DefaultInitializable.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Deque.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Either.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Empty.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/FactoryInitializable.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/FixedSizeArray.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Heap.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/HierarchicalArrays.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/HierarchicalCollection.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/IdIndexable.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/InsertionOrderedDictionary.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/KeyValuePair.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Lens.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/NominalElementDictionary.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/PCGRandomNumberGenerator.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Projections.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Random.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/SourceInitializableCollection.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Tuple.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/Type.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/TypeID.swift /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/UnsignedInteger+Reduced.swift -supplementary-output-file-map /tmp/supplementaryOutputs-9c95c9 -target x86_64-unknown-linux-gnu -disable-objc-interop -I /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release -g -module-cache-path /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/ModuleCache -swift-version 5 -O -D SWIFT_PACKAGE -parse-as-library -module-name PenguinStructures -num-threads 12 -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/AnyArrayBuffer.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/AnyValue.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/ArrayBuffer.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/ArrayStorage.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/CollectionAlgorithms.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Concatenation.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/DefaultInitializable.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Deque.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Either.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Empty.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/FactoryInitializable.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/FixedSizeArray.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Heap.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/HierarchicalArrays.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/HierarchicalCollection.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/IdIndexable.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/InsertionOrderedDictionary.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/KeyValuePair.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Lens.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/NominalElementDictionary.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/PCGRandomNumberGenerator.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Projections.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Random.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/SourceInitializableCollection.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Tuple.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/Type.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/TypeID.swift.o -o /usr/local/google/home/marcrasi/git/penguin/.build/x86_64-unknown-linux-gnu/release/PenguinStructures.build/UnsignedInteger+Reduced.swift.o
1. Swift version 5.3-dev (LLVM d6fb8423828a5e4, Swift 54144acf6a727e9)
2. While evaluating request ExecuteSILPipelineRequest(Run pipelines { PrepareOptimizationPasses, EarlyModulePasses, HighLevel,Function+EarlyLoopOpt, HighLevel,Module+StackPromote, Serialize, MidLevel,Function, ClosureSpecialize, LowLevel,Function, LateLoopOpt, SIL Debug Info Generator } on SIL for PenguinStructures.PenguinStructures)
3. While running pass #25667 SILFunctionTransform "EarlyRedundantLoadElimination" on SILFunction "@$s17PenguinStructures8AnyValueV10storedTypeypXpvg".
for getter for storedType (at /usr/local/google/home/marcrasi/git/penguin/Sources/PenguinStructures/AnyValue.swift:73:14)
#0 0x00000000054b68d4 PrintStackTraceSignalHandler(void*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x54b68d4)
#1 0x00000000054b44ce llvm::sys::RunSignalHandlers() (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x54b44ce)
#2 0x00000000054b6ab5 SignalHandler(int) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x54b6ab5)
#3 0x00007f6856d45140 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14140)
#4 0x00007f6856831db1 raise ./signal/../sysdeps/unix/sysv/linux/raise.c:51:1
#5 0x00007f685681b537 abort ./stdlib/abort.c:81:7
#6 0x00007f685681b40f get_sysdep_segment_value ./intl/loadmsgcat.c:509:8
#7 0x00007f685681b40f _nl_load_domain ./intl/loadmsgcat.c:970:34
#8 0x00007f685682a5b2 (/lib/x86_64-linux-gnu/libc.so.6+0x345b2)
#9 0x000000000120431a (anonymous namespace)::AccessPhiVisitor<(anonymous namespace)::FindAccessBaseVisitor>::findPhiAccess(swift::SILPhiArgument*) && (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x120431a)
#10 0x0000000001203bd5 swift::AccessUseDefChainVisitor<(anonymous namespace)::FindAccessBaseVisitor, swift::SILValue>::visit(swift::SILValue) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x1203bd5)
#11 0x0000000001203763 (anonymous namespace)::FindAccessVisitorImpl<(anonymous namespace)::FindAccessBaseVisitor>::reenterUseDef(swift::SILValue) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x1203763)
#12 0x00000000011fff9e swift::isLetAddress(swift::SILValue) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x11fff9e)
#13 0x0000000000d70da9 swift::SILInstructionVisitor<(anonymous namespace)::MemoryBehaviorVisitor, swift::SILInstruction::MemoryBehavior>::visit(swift::SILInstruction*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xd70da9)
#14 0x0000000000d70c7b swift::AliasAnalysis::computeMemoryBehaviorInner(swift::SILInstruction*, swift::SILValue) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xd70c7b)
#15 0x0000000000d70972 swift::AliasAnalysis::computeMemoryBehavior(swift::SILInstruction*, swift::SILValue) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xd70972)
#16 0x0000000000bad9bb (anonymous namespace)::BlockState::processUnknownWriteInst((anonymous namespace)::RLEContext&, swift::SILInstruction*, RLEKind) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xbad9bb)
#17 0x0000000000ba4625 (anonymous namespace)::RedundantLoadElimination::run() (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xba4625)
#18 0x0000000000aaf492 swift::SILPassManager::runPassOnFunction(unsigned int, swift::SILFunction*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xaaf492)
#19 0x0000000000ab03a7 swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xab03a7)
#20 0x0000000000aad8a8 swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xaad8a8)
#21 0x0000000000aad85b swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xaad85b)
#22 0x0000000000acde3a swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xacde3a)
#23 0x0000000000ab8351 llvm::Expected<swift::ExecuteSILPipelineRequest::OutputType> swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest>(swift::ExecuteSILPipelineRequest const&) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xab8351)
#24 0x0000000000aada85 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xaada85)
#25 0x0000000000abaa3f swift::runSILOptimizationPasses(swift::SILModule&) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0xabaa3f)
#26 0x0000000000690662 swift::CompilerInstance::performSILProcessing(swift::SILModule*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x690662)
#27 0x0000000000514261 performCompileStepsPostSILGen(swift::CompilerInstance&, std::unique_ptr<swift::SILModule, std::default_delete<swift::SILModule> >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x514261)
#28 0x0000000000513c97 performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x513c97)
#29 0x00000000005084fe swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x5084fe)
#30 0x000000000049a7d1 main (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x49a7d1)
#31 0x00007f685681ccca __libc_start_main ./csu/../csu/libc-start.c:308:16
#32 0x000000000049a37e _start (/usr/local/google/home/marcrasi/Downloads/swift-toolchains/master-2020-11-18/swift-DEVELOPMENT-SNAPSHOT-2020-11-18-a-ubuntu20.04/usr/bin/swift-frontend+0x49a37e)
This also affects the tensorflow 0.12 toolchain.
I have figured out a workaround that I will upload a PR for soon.