Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yelay App #432

Open
konstantin-spool opened this issue Jan 10, 2025 · 12 comments
Open

Add Yelay App #432

konstantin-spool opened this issue Jan 10, 2025 · 12 comments
Assignees
@tmjssz @francovenica
Labels
Stale The issue has been inactive for some time. Waiting for Owner The submission is awaiting a response from the owner.

Comments

@konstantin-spool
Copy link

Entry type

  • New addition

App info

URL: https://app.yelay.io/

Manifest.json URL: https://app.yelay.io/manifest.json

Name: Yelay App

Description: Yelay is a decentralized DeFi middleware that connects Capital Aggregators with DeFi Yield Generators to dynamically, automatically, and efficiently allocate funds and ensure optimized yields for customers.

Icon (PNG, 180x180):
image 1

It's minified via https://tinypng.com: no

Homepage: https://www.yelay.io/
Twitter: https://x.com/YieldLayer
GitHub: https://github.com/YieldLayer
Discord: https://discord.gg/dwFgsuTsgw

App supports batching multiple transactions via Safe: yes

Supported networks

- Mainnet
- Arbitrum

Revision checks

  • [/] Used smart contracts were audited.
  • [/] You have implemented the app using the Safe Apps SDK
  • [/] Your Safe App includes a manifest.json file at the root with the required data
  • [/] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • [/] The app auto-connects to the Safe as a wallet
  • [/] It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • [/] You are able to trigger and execute one transaction with a Safe.
  • [/] RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

  1. https://2182024280-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FnZejXGeA67gWdZSLRbwe%2Fuploads%2FeJny2vKrCDCf1jnqzSrN%2Fyelay-token-audit-sept-2024(Public).pdf?alt=media&token=0a3bf0b3-0d18-4034-b894-22c45e96314c

  2. https://www.chainsecurity.com/security-audit/spool-v2-smart-contracts

Code for review

https://github.com/YieldLayer/spool-v2-core

Team information

Company: Yelay

Official website: https://yelay.io

Point of contact: Konstantin Zagaynov, CPO

Email/Telegram: @konstantinius; konstantin@yelay.io
@PooyaRaki PooyaRaki added New New submissions. Awaiting Product Decision The submission the product team attention. and removed New New submissions. labels Jan 10, 2025
@kirkkonen kirkkonen added Ready for Review The app is ready to be reviewed by the reviewers. and removed Awaiting Product Decision The submission the product team attention. labels Jan 13, 2025
@kirkkonen
Copy link

The app was reviewed and approved by the product team.

@konstantin-spool
Copy link
Author

Hi @kirkkonen and team, thank you! Can we expect it to be published in the next few days?

@PooyaRaki
Copy link
Contributor

@konstantin-spool Hi,
The app must first be reviewed by the Tech team, followed by the QA team. It will take at least a couple of weeks to publish the app, provided there are no remarks or issues raised during the review process.
Thanks for you patience.

@PooyaRaki
Copy link
Contributor

Hey @konstantin-spool

I noticed that you only shared the contracts repo with us. Would you be able to share the Frontend app repo as well?
If it's private please share it with @safe-reviewer

Thanks

@konstantin-spool
Copy link
Author

konstantin-spool commented Jan 13, 2025 via email

@konstantin-spool
Copy link
Author

konstantin-spool commented Jan 14, 2025 via email

@tmjssz
Copy link

tmjssz commented Jan 20, 2025

I reviewed the code and approve it.

Non-blocking improvement suggestions:

Ready for QA.

@francovenica francovenica added Ready for Q.A The submission is ready for Q.A. review. and removed Ready for Review The app is ready to be reviewed by the reviewers. labels Jan 21, 2025
@francovenica
Copy link

Some compatibility issues:

1 - Many links in the app open in a new tab, making them not usable for the safe
2 - The selector of network at the top can be switched freely, which is a problem since our safes cannot switch networks. It'd be nice so it only connects to the network the safe is currently on

Image

3 - When you disconnect there is no way to connect again unless you refresh the page. Could you add a option to reconnect to the safe?

Image

@francovenica francovenica added In Q.A The app is currently undergoing Q.A. review. and removed Ready for Q.A The submission is ready for Q.A. review. labels Jan 22, 2025
@konstantin-spool
Copy link
Author

konstantin-spool commented Jan 22, 2025 via email

@francovenica
Copy link

For further clarification, these are the links that open in a new tab.
Thinks like documentation, homepage and the social media links are expected, but not the others

Image

Image

Image

@kirkkonen
Copy link

Hi guys!

From the product PoV, the "new tab" and "chain selector" issues are blockers, while logic on disconnection isn't.

The first two are simple html fixes, no? To change target in the menu items and hide the chain selector?

@francovenica francovenica added Waiting for Owner The submission is awaiting a response from the owner. and removed In Q.A The app is currently undergoing Q.A. review. labels Jan 22, 2025
@konstantin-spool
Copy link
Author

konstantin-spool commented Jan 27, 2025 via email

@PooyaRaki PooyaRaki added the Stale The issue has been inactive for some time. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmjssz tmjssz

@francovenica francovenica

Labels
Stale The issue has been inactive for some time. Waiting for Owner The submission is awaiting a response from the owner.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tmjssz @francovenica @kirkkonen @PooyaRaki @konstantin-spool