Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Domain hash and Message hash fields expandable to show the full string #4827

Open
kadmil opened this issue Jan 25, 2025 · 0 comments
Open

Comments

@kadmil
Copy link

kadmil commented Jan 25, 2025

What is the feature about

The request is to make the fields "Domain hash" and "Message hash" in "Confirm transaction" signing UI expandable, allowing to show the full hash in the same part of the screen. Why asking: I'm an avid ledger hardware wallet user, and every single time I'm signing transactions without execution I have to copy the hashes somewhere (I use vs code for those) to see the full string, allowing a proper check of what I see on hw's screen. While that's a minor inconvenience, it's hindering the process I'm following to be as secure and sure I know what I'm doing as possible. Given there's a known "pick a string with first and last hash symbols matching the known ones" attract vectors (counting on people missing the full hash check), that bug me quite a lot.

The list of requirements

Requirement: the signer can see the full hashes upon signing the transaction on the "Confirm transaction" screen

Designs/sketches

Image
Add a button behind a "copy" one to expand the string; no need for that to be fancy / beautiful

Links

Obvious trigger for the whole convo is Radiant Capital hack:
https://x.com/danielvf/status/1847023591117795708?t=whpr0JATT7WArfgJwgnO9g
https://coinmarketcap.com/community/articles/67129068d08ca0009eb5ab3f/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant