Skip to content

Duplicate & incorrect version resolution when optional dependencies are specified in requirements.txt #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OmkarPh opened this issue Feb 5, 2025 · 3 comments · May be fixed by #401
Open

Duplicate & incorrect version resolution when optional dependencies are specified in requirements.txt #343

OmkarPh opened this issue Feb 5, 2025 · 3 comments · May be fixed by #401
Assignees
@Sahilb315

Comments

@OmkarPh
Copy link
Member

OmkarPh commented Feb 5, 2025

Example requirements.txt

bleach==3.1.2
bleach[css]

Expected - Single bleach package, with version 3.1.2
Actual - Multiple entries for bleach, one with correct version 3.1.2 and another with 0.0.0

Image
@abhisek
Copy link
Member

abhisek commented Mar 17, 2025

@Sahilb315 Adding this for you to look at after you are done with your existing stuff.

@Sahilb315
Copy link
Contributor

Sahilb315 commented Mar 18, 2025 •
edited
Loading

What parser are we using for parsing the requirements.txt file? I am able to get the dependency graph but its not specific to the requirements.txt parsing & can affect other parsers
@abhisek

@abhisek
Copy link
Member

abhisek commented Mar 18, 2025

@Sahilb315 Have a look at: https://github.com/safedep/vet/blob/main/pkg/parser/parser.go#L159

@Sahilb315 Sahilb315 linked a pull request Mar 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sahilb315 Sahilb315

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@abhisek @OmkarPh @Sahilb315