Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remaining hardcoded paths to /home/nemo #67

Open
Olf0 opened this issue Feb 7, 2024 · 1 comment
Open

[Bug] Remaining hardcoded paths to /home/nemo #67

Olf0 opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working enhancement Enhances something feature request feature requests, suggestions, ideas etc.

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Feb 7, 2024

Still a couple of hardcoded paths to /home/nemo remain in src/megacli.cpp, see https://github.com/search?q=repo%3Asailfishos-applications%2Ffilecase+%22/nemo%22&type=code
This also explains, why /home/nemo/.config/cepiperez/… is still used.

Check, if using the folder variable is feasible, as set in src/browser.cpp?

@Olf0
Copy link
Collaborator Author

Olf0 commented Feb 7, 2024

A PR addressing this should adhere to the paths chosen for FileCase's "sister app" FlowPlayer, see FlowPlayer's issue #50 and PR #51.

Actually, the code in FlowPlayer's PR#51 is much more elegant than the quick&dirty solution introduced by commit 7369833 almost three years ago, hence FileCase might adopt FlowPlayers's recent code.

P.S.: See also FileCase's PR #46 (merged) and FlowPlayer's commit f3e8492.

@Olf0 Olf0 changed the title Remaining hardcoded paths to /home/nemo [Bug] Remaining hardcoded paths to /home/nemo Feb 7, 2024
@Olf0 Olf0 added bug Something isn't working enhancement Enhances something feature request feature requests, suggestions, ideas etc. labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhances something feature request feature requests, suggestions, ideas etc.
Projects
None yet
Development

No branches or pull requests

1 participant