Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guzzlehttp/guzzle ^7.0 should be "suggest" in composer.json, not a hard-dependency #82

Open
bernhardberger opened this issue Apr 22, 2021 · 3 comments · May be fixed by #84
Open

guzzlehttp/guzzle ^7.0 should be "suggest" in composer.json, not a hard-dependency #82

bernhardberger opened this issue Apr 22, 2021 · 3 comments · May be fixed by #84

Comments

@bernhardberger
Copy link 

user@notebook:~/PhpStormProjects/my-project $ ddev composer require saintsystems/odata-client

Using version ^0.6.0 for saintsystems/odata-client
./composer.json has been updated
Running composer update saintsystems/odata-client
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires saintsystems/odata-client ^0.6.0 -> satisfiable by saintsystems/odata-client[0.6.0].
    - saintsystems/odata-client 0.6.0 requires guzzlehttp/guzzle ^7.0 -> found guzzlehttp/guzzle[dev-master, 7.0.0-beta.1, ..., 7.4.x-dev (alias of dev-master)] but the package is fixed to 6.5.5 (lock f
ile version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
composer [require saintsystems/odata-client] failed, composer command failed: exit status 2. stderr=
@bernhardberger
Copy link
Author

I just cloned the project, removed the hard dependency on Guzzle 7 and it seems to work just fine with 6.5.5?

Is this hard dependency even neccesary given that you can use the ODataClient using any class implementing the interface? Imho guzzle7 shoul be in the suggest section of the composer.json rather than being a hard dependency..

@bernhardberger bernhardberger changed the title Guzzle dependency in TYPO3 (locked at guzzlehttp/guzzle 6.5.5) guzzlehttp/guzzle ^7.0 should be "suggest" in composer.json, not a hard-dependency May 5, 2021
@bernhardberger bernhardberger linked a pull request May 5, 2021 that will close this issue
Open
@anderly
Copy link
Member

anderly commented May 5, 2021

@bernhardberger, I'll take a look at this. I believe you're right that this could be in the suggest section since any class implementing the interface could be used.

@bernhardberger
Copy link
Author

bernhardberger commented May 5, 2021 •
edited
Loading

Thank you!

At some point switching to a PSR17 (https://www.php-fig.org/psr/psr-17/) / httplug (http://httplug.io/) implementation might be desirable.

PS: #80 is related O think.

@n8rowley n8rowley mentioned this issue Sep 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[!!!][TASK] remove guzzle7 hard dependency ... bernhardberger/odata-client-php
2 participants
@anderly @bernhardberger