-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme issues #94
Comments
You can assign this to me if no one on your team isn't already working on it. |
We have made some fixes to the dark theme locally. I can see if Joe who made the changes can make a pull request. It would at least be a place to start if you have more pressing things. |
jkozar2
added a commit
to jkozar2/attendance
that referenced
this issue
Feb 24, 2022
SAKAI-5974 Modify many points of styling for Dark theme
jkozar2
added a commit
to jkozar2/attendance
that referenced
this issue
Feb 24, 2022
SAKAI-5974 Add new theme-independent sort icons, add theme to datepicker
ottenhoff
pushed a commit
that referenced
this issue
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Certain colors look to be hardcoded and thus look out of place or fail color contrast test when switching to dark theme. Also reported in core jira project (https://sakaiproject.atlassian.net/browse/SAK-46981)
On Attendance tab:
After selecting an item to take attendance:
After selecting an item to take attendance & selecting the Edit attendance item icon:
After selecting an item to take attendance & selecting the Print icon:
After selecting an item to take attendance & scroll over students (odd rows):
After selecting an item to take attendance & selecting a student's name
On Attendance By Student tab:
On Grading tab:
On Settings tab:
The text was updated successfully, but these errors were encountered: