Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: fewer densification steps #3

Open
mukundvarma opened this issue Jun 4, 2021 · 1 comment
Open

Feature request: fewer densification steps #3

mukundvarma opened this issue Jun 4, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mukundvarma
Copy link

mukundvarma commented Jun 4, 2021

Hey Saket,

Thanks for the python port of sctransform! I think it's a great method, and I'm really excited that you're making it accessible to more of the comp bio community with this port.

I've been looking at using pysctransform in my workflows, and I had a feature request. Not sure how easy/feasible it is, but would it be possible to either

  1. replace methods on dense matrices with their sparse counterparts (e.g. here
  2. process the sparse matrix in a chunked manner?

On large datasets (1M+ cells), keeping the dense matrix in memory requires either a prohibitively large and expensive machine, or the steps straight up fail.

I'd be happy to help if you already have some solutions in mind.

@saketkc
Copy link
Owner

saketkc commented Jun 4, 2021

Thanks Mukund, these are both great suggestions! I do have these in my list of todos. In short, the chunking idea is great and should be easy to implement. I will put create a branch and update it here soon with more thoughts.

@saketkc saketkc added the enhancement New feature or request label Jul 6, 2021
@saketkc saketkc self-assigned this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants