From 00545ae15d619f15b5da40d0b354afd774e64ed5 Mon Sep 17 00:00:00 2001 From: saltydk Date: Mon, 5 Feb 2024 00:00:53 +0100 Subject: [PATCH] GHA: remove redundant step --- .github/workflows/saltbox.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/saltbox.yml b/.github/workflows/saltbox.yml index a3986ff0aa..dcc304e6ff 100644 --- a/.github/workflows/saltbox.yml +++ b/.github/workflows/saltbox.yml @@ -160,6 +160,7 @@ jobs: sleep $((attempt * 2)) fi done + if [ $attempt -eq $max_attempts ]; then echo "API requests failed after $max_attempts attempts, defaulting to failure." echo "WORKFLOW_CONCLUSION=failure" >> $GITHUB_ENV @@ -172,13 +173,8 @@ jobs: echo "Some jobs failed." echo "WORKFLOW_CONCLUSION=failure" >> $GITHUB_ENV elif echo "$conclusions" | grep -q "success"; then - if echo "$conclusions" | grep -qv "failure"; then - echo "All jobs succeeded." - echo "WORKFLOW_CONCLUSION=success" >> $GITHUB_ENV - else - echo "Some jobs failed." - echo "WORKFLOW_CONCLUSION=failure" >> $GITHUB_ENV - fi + echo "All jobs succeeded or were skipped." + echo "WORKFLOW_CONCLUSION=success" >> $GITHUB_ENV else echo "Defaulting to failure due to uncertain job conclusions." echo "WORKFLOW_CONCLUSION=failure" >> $GITHUB_ENV