fix: Respect schema names in short FlexNamer
#839
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Awiteb <a@4rs.nl>
|
Hey @chrislearn, is the {
"MyI32": {
"properties": {
"value": {
"format": "int32",
"type": "integer"
}
},
"required": [
"value"
],
"type": "object"
},
"MyObject_u64_": {
"properties": {
"value": {
"format": "int64",
"minimum": 0,
"type": "integer"
}
},
"required": [
"value"
],
"type": "object"
},
"MyStr": {
"properties": {
"value": {
"type": "string"
}
},
"required": [
"value"
],
"type": "object"
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #833
Changes
In this PR, I addressed the issue where
FlexNamerdid not respect the schemaname when generating the short name. Previously,
FlexNamerincorrectly usedthe
type_nameparameter as the short name in theForcerule. This has beencorrected by using the
force_nameparameter as the short name in theForcerule.
Note
This fix only applies to the schema name itself and does not address cases where
the schema name is used as a generic type. Unfortunately, this limitation cannot
be resolved, so please avoid naming your schema if it is intended for use as a
generic type.
Screenshot
This screenshot shows the updated
FlexNamerimplementationBefore
After