Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13.0 changed supported generic types for Option and driver.Valuer interface #50

Open
dropwhile opened this issue Jul 19, 2024 · 1 comment

Comments

@dropwhile
Copy link

It looks like the change to mo.Option Value() [Driver.Valuer interface] supports fewer types than it used to, by now calling DefaultParameterConverter.ConvertValue.

I had some code that was using the output of Value to workaround issues with a validation library, but calling Value() on a mo.Option[[]int] type now fails for any slice types other than []byte.
ref: https://cs.opensource.google/go/go/+/refs/tags/go1.22.5:src/database/sql/driver/types.go;l=286

I have a workaround in place, but dropping this here in case this was not intended, or to help anyone in the future trying to track this down.

@samber
Copy link
Owner

samber commented Jul 25, 2024

Please suggest some changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants