Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does sameersbn/gitlab:14.10.1 use the same source code of gitlab with gitlab/gitlab-ce:14.10.1 ? #2559

Closed
zengqingfu1442 opened this issue May 7, 2022 · 1 comment

Comments

@zengqingfu1442
Copy link

zengqingfu1442 commented May 7, 2022

Only considering the features of gitlab, does sameersbn/gitlab:14.10.1 use the same source code of gitlab with gitlab/gitlab-ce:14.10.1 ? And does sameersbn/gitlab:14.10.1 support the features which are not available on gitlab-ce but available on gitlab-ee ? Thanks.

@kkimurak
Copy link
Contributor

kkimurak commented May 7, 2022

  1. Not exactly. This, sameersbn/gitlab:14.10.1 uses corresponding version of gitlab-foss (gitlab-ce) but modifies some of the code during build (for example :

    # remove HSTS config from the default headers, we configure it in nginx
    exec_as_git sed -i "/headers\['Strict-Transport-Security'\]/d" ${GITLAB_INSTALL_DIR}/app/controllers/application_controller.rb
    # revert `rake gitlab:setup` changes from gitlabhq/gitlabhq@a54af831bae023770bf9b2633cc45ec0d5f5a66a
    exec_as_git sed -i 's/db:reset/db:setup/' ${GITLAB_INSTALL_DIR}/lib/tasks/gitlab/setup.rake
    # change SSH_ALGORITHM_PATH - we have moved host keys in ${GITLAB_DATA_DIR}/ssh/ to persist them
    exec_as_git sed -i "s:/etc/ssh/:/${GITLAB_DATA_DIR}/ssh/:g" ${GITLAB_INSTALL_DIR}/app/models/instance_configuration.rb
    )

  2. No. It only supports gitlab-ce feature. There is a pull request to support gitlab-ee - see Add support for enterprise edition #2329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants