Skip to content

Commit f9be0a6

Browse files
committed
Using context managers better
1 parent d32c725 commit f9be0a6

File tree

2 files changed

+21
-17
lines changed

2 files changed

+21
-17
lines changed

Manager.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ public static async Task Main(string[] args)
99
{
1010
// Make sure Puppeteer has everything it needs downloaded off rip so it won't have to happen during a save or anything
1111
Console.WriteLine("Ensuring the HTML renderer has everything it needs downloaded...");
12-
using var browserFetcher = new BrowserFetcher();
13-
await browserFetcher.DownloadAsync();
12+
using (var browserFetcher = new BrowserFetcher())
13+
{
14+
await browserFetcher.DownloadAsync();
15+
}
1416
Console.WriteLine("Done.");
1517

1618
// First argument might be the absolute path to the directory with all of the save files

Renderer.cs

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -114,22 +114,24 @@ public static async Task generateSaveScreenRender(string absolutePathToSaveDir)
114114

115115
async Task takeScreenshots(string[] htmlPath, string[] pngSavePath)
116116
{
117-
using var browserFetcher = new BrowserFetcher();
118-
await browserFetcher.DownloadAsync();
119-
var browser = await Puppeteer.LaunchAsync(new LaunchOptions
117+
using (var browserFetcher = new BrowserFetcher())
120118
{
121-
Headless = true
122-
});
123-
var page = await browser.NewPageAsync();
124-
await page.SetViewportAsync(new ViewPortOptions
125-
{
126-
Width = 2560,
127-
Height = 1440
128-
});
129-
for(int i = 0; i < htmlPath.Length; i++)
130-
{
131-
await page.GoToAsync(htmlPath[i]);
132-
await page.ScreenshotAsync(pngSavePath[i]);
119+
await browserFetcher.DownloadAsync();
120+
var browser = await Puppeteer.LaunchAsync(new LaunchOptions
121+
{
122+
Headless = true
123+
});
124+
var page = await browser.NewPageAsync();
125+
await page.SetViewportAsync(new ViewPortOptions
126+
{
127+
Width = 2560,
128+
Height = 1440
129+
});
130+
for (int i = 0; i < htmlPath.Length; i++)
131+
{
132+
await page.GoToAsync(htmlPath[i]);
133+
await page.ScreenshotAsync(pngSavePath[i]);
134+
}
133135
}
134136
}
135137

0 commit comments

Comments
 (0)