From 1a89de68d7f296a019bb7cbda99d7002f50d9310 Mon Sep 17 00:00:00 2001 From: Sammy Griffiths Date: Sat, 5 Oct 2024 16:41:25 +0100 Subject: [PATCH 1/2] Reduce subtitle width to better fit on gifs --- src/helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helpers.js b/src/helpers.js index 779adac..9fe89e0 100644 --- a/src/helpers.js +++ b/src/helpers.js @@ -3,7 +3,7 @@ const stringSimilarity = require('string-similarity'); const helpers = { formatSubtitleText: (text) => { - let wrappedText = wrap(text, { width: 28, indent: '' }); + let wrappedText = wrap(text, { width: 26, indent: '' }); let subtitleText = Buffer.from(wrappedText).toString('base64'); let replacedSlashText = subtitleText.replace(/\//g, '_'); let replacedPlusText = replacedSlashText.replace(/\+/g, '-'); From d754581a421f2c7ddf510a1267f2bf076ba67eb4 Mon Sep 17 00:00:00 2001 From: Sammy Griffiths Date: Sat, 5 Oct 2024 16:56:26 +0100 Subject: [PATCH 2/2] Fix failing tets --- test/src/api.test.js | 6 +++--- test/src/helpers.test.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/src/api.test.js b/test/src/api.test.js index ccb1385..90a3d68 100644 --- a/test/src/api.test.js +++ b/test/src/api.test.js @@ -110,7 +110,7 @@ describe('API', () => { Content: text }; - let expectedText = 'VGhpcyBpcyBhIGxvbmcgcGllY2Ugb2YgdGV4dCAKdGhhdCBuZWVkcyB0byBiZSBzcGxpdCBvbiB0byAKbXVsdGlwbGUgbGluZXM_Pz8_Pz4-Pj4-'; + let expectedText = 'VGhpcyBpcyBhIGxvbmcgcGllY2Ugb2YgCnRleHQgdGhhdCBuZWVkcyB0byBiZSAKc3BsaXQgb24gdG8gbXVsdGlwbGUgCmxpbmVzPz8_Pz8-Pj4-Pg=='; let expectedUrl = 'https://frinkiac.com/gif/S07E21/1/2.gif?b64lines=' + expectedText; const axios = { @@ -154,7 +154,7 @@ describe('API', () => { }); describe('generateGif', () => { it('gets the appropriate gif from frinkiac', async () => { - let expectedUrl = 'https://frinkiac.com/video/S10E07/MI9Rd6R0gNkiZnr2cFb_wA8vC3k=.gif'; + let expectedUrl = 'https://frinkiac.com/video/S10E07/2BgqWeuWjvumnQewtcAinhUVhXU=.gif'; let term = 'super nintendo chalmers'; let result = await api(require('axios'), config).generateGif(term); @@ -172,7 +172,7 @@ describe('API', () => { }).timeout(10000); it('gets the appropriate gif from frinkiac with multiple captions', async () => { - let expectedUrl = 'https://frinkiac.com/video/S06E08/FudWxOoaKmj_5Sk8zzxbYtTqot4=.gif'; + let expectedUrl = 'https://frinkiac.com/video/S06E08/CXUO_0Mn1AupcjkdvINxh3hzaSQ=.gif'; let term = "We'd ask you to come, but... You know..."; let result = await api(require('axios'), config).generateGif(term); diff --git a/test/src/helpers.test.js b/test/src/helpers.test.js index f052e92..514200a 100644 --- a/test/src/helpers.test.js +++ b/test/src/helpers.test.js @@ -14,7 +14,7 @@ describe('helpers', () => { it('adds line breaks in the text where appropriate', () => { let text = 'This is a long piece of text that needs to be split on to multiple lines'; - let expectedText = 'VGhpcyBpcyBhIGxvbmcgcGllY2Ugb2YgdGV4dCAKdGhhdCBuZWVkcyB0byBiZSBzcGxpdCBvbiB0byAKbXVsdGlwbGUgbGluZXM='; + let expectedText = 'VGhpcyBpcyBhIGxvbmcgcGllY2Ugb2YgCnRleHQgdGhhdCBuZWVkcyB0byBiZSAKc3BsaXQgb24gdG8gbXVsdGlwbGUgbGluZXM='; let returnedText = helpers.formatSubtitleText(text);