Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Library function to get catalogue #222

Closed
patrickskowronekdkfz opened this issue Feb 13, 2025 · 1 comment · Fixed by #217
Closed

[Feature]: Add Library function to get catalogue #222

patrickskowronekdkfz opened this issue Feb 13, 2025 · 1 comment · Fixed by #217

Comments

@patrickskowronekdkfz
Copy link
Collaborator

General Summary

The function getCriteriaAPI returns a part of the catalogue, with #217 deprecated and should be remove in v0.4.7. However, this function should not be lost.

I would rather get a subscribable writeable of the catalogue to modify or search the catalogue.

Suggested Change

Add getCatalog()

Is this Breaking?

Yes

Current Behavior

getCriteria(String)

New Behavior

Detailed Description
Merged
@timakro
Copy link
Collaborator

timakro commented Feb 13, 2025 •
edited
Loading

Usually the catalogue is passed in by the application anyways, right? So they would already know about it. Nevertheless I'm not opposed to adding a getCatalogue() API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate getCriteriaAPI samply/lens
2 participants
@timakro @patrickskowronekdkfz